-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify resource warming docs in xds protocol #22377
Changes from 5 commits
2b0b1a3
4040109
e207f6b
0858246
ceaf541
a0c5cb1
eb2fdfd
a4a6bd8
5ef74d6
e7400fd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -678,6 +678,14 @@ server does not provide EDS/RDS responses, Envoy will not initialize | |
itself during the initialization phase and the updates sent via CDS/LDS | ||
will not take effect until EDS/RDS responses are supplied. | ||
|
||
.. note:: | ||
|
||
Envoy specific implementation note: Warming of ``Cluster`` is completed only | ||
when a new ``ClusterLoadAssignment`` response is supplied by management server | ||
even though there is no change in endpoints. However, If Envoy is already aware of | ||
``RouteConfiguration`` referenced by ``Listener``, it will use it otherwise Envoy will | ||
initiate a new RDS request with the new route name referenced by ``Listener``. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can't parse this. Is this related to Cluster or unrelated and a different note about warming? Can you clarify and if it's different move it to a separate note? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is about listener warming with route. It is under same resource warming category. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK then I don't understand this and how it relates to the cluster part. Can you clarify? Thanks. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not related to cluster warming. It is related to resource warming only but talks about how listeners are warmed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then please split it out into a separate note and/or make it a clearly separate statement. I'm having a hard time parsing what this means. Thank you! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I clarified it. PTAL |
||
|
||
.. _xds_protocol_eventual_consistency_considerations: | ||
|
||
Eventual consistency considerations | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?