Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix example composition build instructions #22132

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

phlax
Copy link
Member

@phlax phlax commented Jul 12, 2022

Follow on fix for #20915

Signed-off-by: Ryan Northey [email protected]

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Follow on fix for envoyproxy#20915

Signed-off-by: Ryan Northey <[email protected]>
@repokitteh-read-only
Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22132/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: #22132 was opened by phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Jul 12, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22132 (comment) was created by @phlax.

see: more, trace.

@phlax phlax changed the title docs: Fix example build instructions docs: Fix example composition build instructions Jul 12, 2022
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlax phlax merged commit 181bd2a into envoyproxy:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants