-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] v2-api: rate limit (tcp, http), client ssl auth #2126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shriram Rajagopalan <[email protected]>
Signed-off-by: Shriram Rajagopalan <[email protected]>
Signed-off-by: Shriram Rajagopalan <[email protected]>
Signed-off-by: Shriram Rajagopalan <[email protected]>
htuch
previously approved these changes
Nov 30, 2017
source/common/config/filter_json.h
Outdated
envoy::api::v2::filter::network::TcpProxy& proto_config); | ||
|
||
/** | ||
* Translate a v1 JSON Tcp Rate Limit filter object to v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: s/Tcp/TCP/
Signed-off-by: Shriram Rajagopalan <[email protected]>
Signed-off-by: Shriram Rajagopalan <[email protected]>
Signed-off-by: Shriram Rajagopalan <[email protected]>
Signed-off-by: Shriram Rajagopalan <[email protected]>
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
…oxy#2126) * Deflake macos MixerFaultTest by broadening assertion ranges. Fix flake in macos tests that was introduced by envoyproxy#2113 * Cleanup a few readability issues and add an assertion. * More redability changes.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Rafal Augustyniak <[email protected]> Description: Generate symbol mapping file as opposed to symbol table mapping file as it contains more information. Bugsnag's guide explaining the difference between symbol table mapping files and symbol mapping files and how to generate the latter can be found at https://docs.bugsnag.com/api/ndk-symbol-mapping-upload/#uploading-mapping-files. See this Bugsnag Android Github issue bugsnag/bugsnag-android#1609. Risk Level: Low, affects debugging features only, not production code Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Rafal Augustyniak <[email protected]> Description: Generate symbol mapping file as opposed to symbol table mapping file as it contains more information. Bugsnag's guide explaining the difference between symbol table mapping files and symbol mapping files and how to generate the latter can be found at https://docs.bugsnag.com/api/ndk-symbol-mapping-upload/#uploading-mapping-files. See this Bugsnag Android Github issue bugsnag/bugsnag-android#1609. Risk Level: Low, affects debugging features only, not production code Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: v2-api: rate limit (tcp, http), client ssl auth
Description:
Migrate rate limit, client ssl auth filters to v2 api. And some cleanups
Risk Level: Low
Testing: Existing tests for these filters, in addition to some unit tests to check V2 api compatibility
Signed-off-by: Shriram Rajagopalan [email protected]