lua: fix respond() status code checks #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Klein <[email protected]>
Closed
htuch
approved these changes
Nov 9, 2017
| @@ -1171,7 +1171,7 @@ TEST_F(LuaHttpFilterTest, ImmediateResponse) { | |||
| const std::string SCRIPT{R"EOF( | |||
| function envoy_on_request(request_handle) | |||
| request_handle:respond( | |||
| {[":status"] = "403"}, | |||
| {[":status"] = "503"}, | |||
There was a problem hiding this comment.
Why change this test response code? Both are in range..
There was a problem hiding this comment.
Because this was what was broken before the change. :)
We test 4xx codes elsewhere.
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
To use --distdir option of Bazel (which allows to use previously fetched tarballs instead of downloading dependencies during build), all dependencies should use http instead of git and need to have sha256 sums specified. Signed-off-by: Michal Rostecki <[email protected]>
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* Improve performance by removing MD5 for check cache keys (envoyproxy#2002) * Improve performance by removing MD5 for check cache keys Signed-off-by: Wayne Zhang <[email protected]> * not to allocate memory from stack Signed-off-by: Wayne Zhang <[email protected]> * Make debug string readable Signed-off-by: Wayne Zhang <[email protected]> * alts: remove ALTS (envoyproxy#2003) Signed-off-by: Lizan Zhou <[email protected]> * Use std::hash for check cache. (envoyproxy#2009) Signed-off-by: Wayne Zhang <[email protected]> * Remove tests to compare signature values (envoyproxy#2015) Signed-off-by: Wayne Zhang <[email protected]> * update sample envoy config to latest version (envoyproxy#2016) * Add a new TCP cluster rewrite filter (envoyproxy#2017) * Add a new TCP cluster rewrite filter This commit adds a new TCP cluster rewrite filter which allows users to rewrite TCP cluster names obtained via TLS SNI by matching via regex configuration. Signed-off-by: Venil Noronha <[email protected]> * Make TCP cluster rewrite stackable on SNI filter This commit updates the TCP Cluster Rewrite filter to be stackable on the SNI Cluster filter. Signed-off-by: Venil Noronha <[email protected]> * Update TCP Cluster Rewrite filter name (envoyproxy#2019) This commit updates the TCP Cluster Rewrite filter name to envoy.filters.network.tcp_cluster_rewrite. Signed-off-by: Venil Noronha <[email protected]> * Enable TCP Cluster Rewrite filter registration (envoyproxy#2021) This commit enables the static registration of the TCP Cluster Rewrite filter by updating the build configuration. Signed-off-by: Venil Noronha <[email protected]> * Update Envoy SHA to 4ef8562 (envoyproxy#2023) Envoy /server_info API was inconsistent intermittently causing errors on a Proxy update on Istio. This update will bring in the API fix to Istio. Signed-off-by: Venil Noronha <[email protected]> * add proxy postsubmit periodic (envoyproxy#2025) * Update Envoy SHA to c41fa71 (envoyproxy#2029) * Update Envoy SHA Signed-off-by: JimmyCYJ <[email protected]> * Fix format. Signed-off-by: JimmyCYJ <[email protected]> * bazel: Allow to distdir all dependencies (envoyproxy#2034) To use --distdir option of Bazel (which allows to use previously fetched tarballs instead of downloading dependencies during build), all dependencies should use http instead of git and need to have sha256 sums specified. Signed-off-by: Michal Rostecki <[email protected]> * bazel: Remove BoringSSL repository (envoyproxy#2035) Pull request envoyproxy#2002 removed signature calculation which was using BoringSSL as a dependency. BoringSSL is not needed anymore. Signed-off-by: Michal Rostecki <[email protected]> * Update Envoy SHA to fcc68f1 (envoyproxy#2037) * Update Envoy SHA to fcc68f1 Signed-off-by: JimmyCYJ <[email protected]> * Update SHA256 Signed-off-by: JimmyCYJ <[email protected]>
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
* Update Envoy: 71248e5...bbcd487 * Remove various `remotejdk_11` configurations in .bazelrc which we now inherit from Envoy * Work around https://github.com/bazelbuild/bazel/issues/14260 androidndk fetching issue Signed-off-by: JP Simard <[email protected]> Co-authored-by: Keith Smiley <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
* Update Envoy: 71248e5...bbcd487 * Remove various `remotejdk_11` configurations in .bazelrc which we now inherit from Envoy * Work around https://github.com/bazelbuild/bazel/issues/14260 androidndk fetching issue Signed-off-by: JP Simard <[email protected]> Co-authored-by: Keith Smiley <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.