runtime: removing singleton access from validator #20015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
daixiang0
approved these changes
Feb 18, 2022
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
|
/wait |
Signed-off-by: Alyssa Wilk <[email protected]>
|
huh, the failing test seems unrelated. I'll try a main merge in case something else changed. |
mattklein123
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Thanks this makes sense to me. Happy to merge this as I will have to merge this into #20111. Thank you for slogging through this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does make the deprecation stats have the same problem as the WIP stats, which is that using getStrictValidationVisitor doesn't update deprecation stats. I could do the same trick in source as I did in test and cast-and-set if we have concerns about that.
Risk Level: low
Testing: existing tests
Docs Changes: n/a
Release Notes: n/a
Part of #19847