[Backport 1.18] Enable Windows workers (#17555) #17814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2021 14:23
Fixing an issue where Envoy workers are not picking up connections on Windows. The root cause of the issue is in the Windows kernel. There are two issues that we need to consider: If we want to listen from a duplicated socket then we need to duplicate it after we call listen on the original socket. If duplicated sockets try to accept at the same time, then one of the accept calls might block. Even if the sockets are non-blocking. The best way to work around that issue is to only listen/accept connections from the first worker thread and then use ExactConnectionBalance to dispatch the connection to another worker thread. This is a temporary solution until the underlying issue is fixed on Windows. Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
davinci26
force-pushed
the
v18CpFixWorkersFix
branch
from
389949b to
bab6c80
Compare
Signed-off-by: Sotiris Nanopoulos <[email protected]>
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Sotiris Nanopoulos <[email protected]>
|
cc @wrowe |
davinci26
added
backport/review
dmitri-d
reviewed
Aug 24, 2021
|
This lgtm, but with a fat warning that I don't know much about Windows idiosyncrasies. |
|
/retest |
|
Retrying Azure Pipelines: |
|
Need to merge main here, I believe compile_time_options phase is fixed on main. |
|
#17868 needs to land beforehand. |
|
@mathetake was correct, need to merge to branch one more time here @davinci26 and I think it will pass CI to be merged. |
added 2 commits
August 30, 2021 17:18
Signed-off-by: Sotiris Nanopoulos <[email protected]>
wrowe
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Backport 1260c5c to 1.18
Fixing an issue where Envoy workers are not picking up connections on Windows.
The root cause of the issue is in the Windows kernel.
There are two issues that we need to consider:
If we want to listen from a duplicated socket then we need to duplicate it after we call listen on the original socket.
If duplicated sockets try to accept at the same time, then one of the accept calls might block. Even if the sockets are non-blocking.
The best way to work around that issue is to only listen/accept connections from the first worker thread and then use ExactConnectionBalance to dispatch the connection to another worker thread. This is a temporary solution until the underlying issue is fixed on Windows.
Signed-off-by: Sotiris Nanopoulos [email protected]
Risk Level: Low
Testing: Manual testing and tests
Docs Changes: Added
Release Notes: Added a bug fix note
Platform Specific Features: N/A