Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional: make coverity happy #1767

Merged
merged 3 commits into from
Sep 28, 2017
Merged

optional: make coverity happy #1767

merged 3 commits into from
Sep 28, 2017

Conversation

mattklein123
Copy link
Member

Signed-off-by: Matt Klein [email protected]

htuch
htuch previously approved these changes Sep 28, 2017
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to add a TODO to replace with Abseil's optional? The optional in Abseil is intended to be C++17 forward compatible.

@mattklein123
Copy link
Member Author

@htuch updated

@mattklein123 mattklein123 merged commit 8a95827 into master Sep 28, 2017
@mattklein123 mattklein123 deleted the coverity_fix branch September 28, 2017 20:52
costinm pushed a commit to costinm/envoy that referenced this pull request Oct 2, 2017
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
* Update api sha (envoyproxy#1753)

* Release-0.8: Update envoy sha to bb6762a (envoyproxy#1759)

* Update envoy sha to bb6762a

* update envoy sha to 12c470e

* fix authn/integration tasn issue

* Update_Dependencies (envoyproxy#1766)

* Build addition artifacts with debug symbols (envoyproxy#1767)

* Update_Dependencies (envoyproxy#1768)
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
…roxy#1780)

* Update api sha (envoyproxy#1753)

* Release-0.8: Update envoy sha to bb6762a (envoyproxy#1759)

* Update envoy sha to bb6762a

* update envoy sha to 12c470e

* fix authn/integration tasn issue

* Update_Dependencies (envoyproxy#1766)

* Build addition artifacts with debug symbols (envoyproxy#1767)

* Update_Dependencies (envoyproxy#1768)

* Update api version to b549a3f770c833bad8f4f3871768c43960ab7309 (envoyproxy#1769)

* Update istio.deps

* Update repositories.bzl

* Update istio.deps

* Update istio.deps

* Update Envoy to c2baf34. (envoyproxy#1773)

Signed-off-by: Piotr Sikora <[email protected]>

* Update api sha to 8d67e57e3612dae1a3423795bce93a372cfe4fa4 (envoyproxy#1775)

* revert api sha change
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: Mike Schore <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Mike Schore <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants