-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deps] add scorecard info in external dep table #17206
Conversation
Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
/lgtm deps |
docs are rendered here https://storage.googleapis.com/envoy-pr/17206/docs/index.html eg, relevant page is here https://storage.googleapis.com/envoy-pr/d2c8f79/docs/intro/arch_overview/security/external_deps.html |
@asraa it would be good to have some explanation or a link to get some context to the scorecard info |
Yeah, looking at https://storage.googleapis.com/envoy-pr/d2c8f79/docs/intro/arch_overview/security/external_deps.html, I think the table is not making things super clear yet. We should have links from each criteria or a tool tip to what it is about. Also, the formatting needs some work. Maybe some color coding, table-in-table, whatever creative ideas folks have to make this easier for a human to parse as they scan down. |
(FYI this PR is now 14 days stale) |
What if instead of printing out the results (which I still can't figure out how to format properly through sphinx), I linked to the deps.dev links? e.g. https://deps.dev/go/github.com%2Fgrpc%2Fgrpc which embed the scorecard a lot nicer than I could? |
I think this could wort too. |
/wait |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Asra Ali [email protected]
Commit Message: Adds scorecard evaluation into the external dependency documentation.
Additional Description:
Risk Level: Low
Testing: Generated docs
Docs Changes: This is it.
[Optional Fixes #Issue] Related to #10471
I'm still working on formatting the output nicely inside the table, rendering newlines through sphinx in the csv table text has been a pain, but I think I will figure it out soon.