add version_info to onConfigUpdate and /routes output #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 5, 2017 09:31
htuch
reviewed
Sep 5, 2017
There was a problem hiding this comment.
High level question. I had envisaged that the Subscription objects would maintain version, and provide it to whoever wanted to know this. It avoids the need to maintain this state in multiple locations and potential inconsistency with the accepted/rejected state. Can we add versionInfo() to the Subscription interface instead of passing into onConfigUpdate()?
|
agreed, i like that better @htuch. will put together a PR. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Risk Level: low Testing: Docs Changes: inline Part of #1594 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Converts EM's responseFlags to Cronet's API Errors Additional Description: Note that this change does not include ERR_NETWORK_CHANGED, ERR_INTERNET_DISCONNECT and QUIC_PROTOCOL_FAILED as they aren't implemented yet Risk Level: Low Testing: Test included Docs Changes: n/a Release Notes: n/a Signed-off-by: Chidera Olibie <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Risk Level: low Testing: unit tests Docs Changes: n/a Release Notes: yes Part of #1594 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: As a follow up for PR2568, the PR maps the network_disconnected and quic exception errors. The network_changed error has been removed as this is not relevant to envoymobile. Signed-off-by: Chidera Olibie <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Risk Level: low Testing: Docs Changes: inline Part of #1594 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Converts EM's responseFlags to Cronet's API Errors Additional Description: Note that this change does not include ERR_NETWORK_CHANGED, ERR_INTERNET_DISCONNECT and QUIC_PROTOCOL_FAILED as they aren't implemented yet Risk Level: Low Testing: Test included Docs Changes: n/a Release Notes: n/a Signed-off-by: Chidera Olibie <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Risk Level: low Testing: unit tests Docs Changes: n/a Release Notes: yes Part of #1594 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: As a follow up for PR2568, the PR maps the network_disconnected and quic exception errors. The network_changed error has been removed as this is not relevant to envoymobile. Signed-off-by: Chidera Olibie <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.