test: fix //test/common/upstream:cluster_manager_impl_test_lib. #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was broken by interaction of envoyproxy#1521 and envoyproxy#1570.
mattklein123
approved these changes
Aug 31, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: API for addDnsQueryTimeoutSeconds to configure behavior introduced in #1580 Risk Level: low - optional builder API Testing: updated suite. Docs Changes: added Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: API for addDnsQueryTimeoutSeconds to configure behavior introduced in #1580 Risk Level: low - optional builder API Testing: updated suite. Docs Changes: added Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was broken by interaction of #1521 and #1570.