Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCM: add support for IP detection extensions #14855

Merged
merged 175 commits into from
May 16, 2021
Merged

HCM: add support for IP detection extensions #14855

merged 175 commits into from
May 16, 2021

Commits on Jan 28, 2021

  1. HCM: add support for IP detection extensions 

    This is a follow-up to:

envoyproxy#14432 (comment)

After that PR, it's no longer possible (unless you do a dynamic_cast)
to set the remote address from a filter. This is something that we
need to do because we have specialized logic for this (XFF doesn't
work for us).

So this adds an extension point which will allow us to push that logic
down to ConnectionManagerUtility::mutateRequestHeaders() where it
belongs.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    2be9bdd View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    e55d622 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Rename --> original_ip_detection 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    eee3cd5 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    e8d890a View commit details
    Browse the repository at this point in the history

  3. Update changelog 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    03819df View commit details
    Browse the repository at this point in the history

  4. Some docs 

    Not sure where to put a full example of how to configure an extension.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    701e979 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Add HCM config tests 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    68c9785 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    c525fa0 View commit details
    Browse the repository at this point in the history

  3. Add test for mutateRequestHeaders() using an extension 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    b42737b View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    9a4421d View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Use TypedExtensionConfig 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    09a28e2 View commit details
    Browse the repository at this point in the history

  2. Extensive comments around the config message 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    2358acb View commit details
    Browse the repository at this point in the history

  3. Fix test 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    445d0b2 View commit details
    Browse the repository at this point in the history

  4. Fix another test 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    c8b4115 View commit details
    Browse the repository at this point in the history

  5. clang-tidy fixes 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    0868c1e View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    986f598 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    1552d08 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    d2b691a View commit details
    Browse the repository at this point in the history

  2. Add integration test 

    This should probably suffice as a guide for adding new IP
detection extensions.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    def62d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    a44ce6f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    c48840a View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    b8d50d9 View commit details
    Browse the repository at this point in the history

  2. Address Alyssa's review. 

    Just saw Antonio's review come in, I'll address those comments
in a follow-up.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    8634819 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    6193ad2 View commit details
    Browse the repository at this point in the history

  4. Don't copy downstream_remote_address 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    7d4d71b View commit details
    Browse the repository at this point in the history

  5. Fix build 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    b30ce45 View commit details
    Browse the repository at this point in the history

  6. Drop struct 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    406d825 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    8832af6 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Review feedback 

    * Use a Result type for detect()
* add CustomHeader as an included extension
* more fixes

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    7440409 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    8ebd8b8 View commit details
    Browse the repository at this point in the history

  3. Implement/Exercise allow_trusted_address_checks option 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    3960337 View commit details
    Browse the repository at this point in the history

  4. Drop struct 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    24a45b0 View commit details
    Browse the repository at this point in the history

  5. Add XFF detection extension 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    612ae54 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    2937e99 View commit details
    Browse the repository at this point in the history

  7. Use the XFF extension as the default fallback 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    9db5c61 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Add support for rejecting requests when detection fails 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    3608dbf View commit details
    Browse the repository at this point in the history

  2. Fixes for CI 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    1190035 View commit details
    Browse the repository at this point in the history

  3. Fix docs 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    970b42b View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2021

  1. Fix spelling 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    2e5e67f View commit details
    Browse the repository at this point in the history

  2. Code owners 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    a23f44f View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Fix test 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    5bd6813 View commit details
    Browse the repository at this point in the history

  2. Fix clang-tidy issue 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    bd00e7f View commit details
    Browse the repository at this point in the history

  3. Fix coverage 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    178d287 View commit details
    Browse the repository at this point in the history

  4. Check that a good detection doesn't set rejection options 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    802c379 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    151f5f8 View commit details
    Browse the repository at this point in the history

  2. Review comments 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    8f5165b View commit details
    Browse the repository at this point in the history

  3. Add stat for ip detection rejections 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    a246e9e View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    d86f908 View commit details
    Browse the repository at this point in the history

  5. Remove possible exception from data path 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    e2fc581 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Matt's review comments 

    * use repeated TypedExtensionConfig for configuring extensions
* no need to default to XFF when a list of extensions is provided

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    7476d1a View commit details
    Browse the repository at this point in the history

  2. clang tidy 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    370c16d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    aa7306c View commit details
    Browse the repository at this point in the history

  4. Drop mostly duplicated extension for test 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    1e1ac79 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    3eca009 View commit details
    Browse the repository at this point in the history

  6. More CI fixes 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    e32eef6 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    5871471 View commit details
    Browse the repository at this point in the history

  8. Fix merge 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    f0e29ae View commit details
    Browse the repository at this point in the history

  9. More cleanup 

    * fix bug in HCM (message needed translation)
* drop helper classes for tests, use real extensions directly

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    92c0ed4 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    a20c9bb View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Fix format 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    ac430bb View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    4446232 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    d2fec64 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    b60a227 View commit details
    Browse the repository at this point in the history

  2. Fixes 

    * envoy.original_ip_detection -> envoy.http....
* get rid of common proto message
* mark xff_num_trusted_hops as deprecated

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    822aa25 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    b14fe36 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    a1edf65 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    79a6282 View commit details
    Browse the repository at this point in the history

  2. Rename config param to allow_extension_to_set_address_as_trusted 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    8ad18c6 View commit details
    Browse the repository at this point in the history

  3. Update header to reflect we now support a list of extensions 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    9a0d41b View commit details
    Browse the repository at this point in the history

  4. Alyssa's feedback 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    4043a4a View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    0bd4551 View commit details
    Browse the repository at this point in the history

  6. Fix deprecation error in test 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    f873002 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    b9d2949 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    cc2dc36 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    ca7bd7e View commit details
    Browse the repository at this point in the history

  4. Force registration of the XFF extension 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    98bb064 View commit details
    Browse the repository at this point in the history

  5. Visibility public for XFF config 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    a523594 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    9861c9d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    820f866 View commit details
    Browse the repository at this point in the history

  3. Fix merge 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    63b8f2c View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    4fa79d7 View commit details
    Browse the repository at this point in the history

  5. Fix merge leftover 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    056db7c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3885ec4 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    d33994c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    af498c8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    309b1b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    977f42b View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    24b9de8 View commit details
    Browse the repository at this point in the history

  2. Fix merge 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    d0a99c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    6a85d81 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    c4188ce View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    ab19e4d View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    02d9c88 View commit details
    Browse the repository at this point in the history

  2. Fix merge 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    684c8af View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    a226897 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    728fa54 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    bb2ec49 View commit details
    Browse the repository at this point in the history

  2. Fix merge snafu 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8a692d6 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    222eeae View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    4adad84 View commit details
    Browse the repository at this point in the history

  2. Add code block example for replacing xff_num_trusted_hops 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    8568494 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Alyssa's feedback (partial) 

    There are 3 items pending, we'll discuss them offline or via
comments.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    cd9b360 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    0647ad9 View commit details
    Browse the repository at this point in the history

  3. Fix build 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    57443bd View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    d6bbeaa View commit details
    Browse the repository at this point in the history

  5. Fix 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    99bd132 View commit details
    Browse the repository at this point in the history

  6. Fix test 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    ea48936 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    63ccd3f View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    7c78b24 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Address latest batch of comments 

    Left a comment/TODO about the proper protobuf type the createExtension()
method should receive.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    a823d94 View commit details
    Browse the repository at this point in the history

  2. Test for createExtension() returning nullptr 

    Also, the HCM test broke in my last change so this fixes it.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    e4b99bc View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    19180ff View commit details
    Browse the repository at this point in the history

  4. Add extension name to the exception message 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    f8df690 View commit details
    Browse the repository at this point in the history

  5. Test case for v6 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    7ce524e View commit details
    Browse the repository at this point in the history

  6. clang-tidy 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    bd05e1a View commit details
    Browse the repository at this point in the history

  7. custom header: improve coverage 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    95779af View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    18f02c3 View commit details
    Browse the repository at this point in the history

  9. Set the custom header extension to out by default 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    516de72 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Update headers.rst to reflect the use of IP detection extensions 

    I probably still need to update the configuration examples in that file,
otherwise they'll go stale soon.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    63a3987 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    d0f50da View commit details
    Browse the repository at this point in the history

  3. extensions/ -> extensions/http/ 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    305f2ed View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    7fe2d81 View commit details
    Browse the repository at this point in the history

  5. Reduce (or hide) the dynamic_cast calls 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    29af4d3 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    336261c View commit details
    Browse the repository at this point in the history

  7. Fix visibility comments 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    720d541 View commit details
    Browse the repository at this point in the history

  8. More comment fixes 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    de30bd9 View commit details
    Browse the repository at this point in the history

  9. Validate header name 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    ab852ff View commit details
    Browse the repository at this point in the history

  10. More fixes 

    * improve test
* fix namespacing issue now that we have Extensions::Http confuses things
  referencing Envoy::Http

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    4582469 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. More namespaces fixes 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    8ec2a83 View commit details
    Browse the repository at this point in the history

  2. Expand integration test 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    129b0bf View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    6ac62e6 View commit details
    Browse the repository at this point in the history

  4. Validate header name 

    I am unsure what the right approach for enforcing validation is:

1) setting `strict: true` in the proto file (most likely not)
2) using ProtobufMessage::getStrictValidationVisitor() instead of the context validator
3) forcing the test to do strict validation

I went with 1) for now, otherwise regex validation isn't happening
in the added test.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    c338b65 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    c2717ba View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    800b843 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    5070b90 View commit details
    Browse the repository at this point in the history

  3. Matt's feedback 

    * rename single_address_
* disable docs for custom key
* avoid namespace pollution
* document proto restrictions for status_code

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    91806ca View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    5f15518 View commit details
    Browse the repository at this point in the history

  5. Update changelog 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    014d6d4 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    15dc56a View commit details
    Browse the repository at this point in the history

  7. Fix changelog 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    eaca63d View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    9b0f98b View commit details
    Browse the repository at this point in the history

  2. Fix current changelog 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    a241827 View commit details
    Browse the repository at this point in the history

  3. Bring back the custom header extension 

    It's more painful to have it excluded since we still want/need
to reference it from multiple places because it's a useful
example of how this extension point works.

So at the cost of forcing deployments to exclude it manually,
let's bring it back.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    bffe4d1 View commit details
    Browse the repository at this point in the history

  4. Fix format 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    991996b View commit details
    Browse the repository at this point in the history

  5. Avoid namespace pollution issues 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    73aad95 View commit details
    Browse the repository at this point in the history

  6. Another test fix 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    6cd3d43 View commit details
    Browse the repository at this point in the history

  7. Another test fix 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    42776e9 View commit details
    Browse the repository at this point in the history

  8. Fix 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    7e6da84 View commit details
    Browse the repository at this point in the history

  9. Format 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    ef56193 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    04b19b9 View commit details
    Browse the repository at this point in the history

  11. Fix integration tests 

    Registering XFF with _required_extensions isn't enough, needs
to be part of _core_extensions too.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    66f2296 View commit details
    Browse the repository at this point in the history

  12. extensions/common/aws needs xff to run 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    b78ba36 View commit details
    Browse the repository at this point in the history

  13. xff:config should have been a dep of hcm:config in the prev commit 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    16a736e View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2021

  1. HCM's test needs the custom header extension 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    fcf7945 View commit details
    Browse the repository at this point in the history

  2. clang-tidy 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    098ecd5 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    081e731 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c025400 View commit details
    Browse the repository at this point in the history

  3. Undo jwt proto formatting 

    Not sure what triggered this, probs something in my env.

Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    ff6b944 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    09c84e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    cef2d20 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    e1f0ac5 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    145809a View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    a62ede7 View commit details
    Browse the repository at this point in the history

  2. Fallback -> fall back 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    0eac980 View commit details
    Browse the repository at this point in the history

  3. Comment on allow trusted check 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    c751398 View commit details
    Browse the repository at this point in the history

  4. Status code comment 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    bafa351 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed May 13, 2021
    Configuration menu
    Copy the full SHA
    f9a372c View commit details
    Browse the repository at this point in the history

  2. Fix merge 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed May 13, 2021
    Configuration menu
    Copy the full SHA
    892a4a8 View commit details
    Browse the repository at this point in the history

  3. Trim down comment for original_ip_detection_extensions 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed May 13, 2021
    Configuration menu
    Copy the full SHA
    fd10840 View commit details
    Browse the repository at this point in the history

  4. More fixes 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed May 13, 2021
    Configuration menu
    Copy the full SHA
    3ef96b1 View commit details
    Browse the repository at this point in the history

  5. Field name update 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed May 13, 2021
    Configuration menu
    Copy the full SHA
    f841b5f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Fix 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed May 14, 2021
    Configuration menu
    Copy the full SHA
    c4a21e7 View commit details
    Browse the repository at this point in the history

  2. htuch's review 

    Signed-off-by: Raul Gutierrez Segales <[email protected]>
    Raul Gutierrez Segales committed May 14, 2021
    Configuration menu
    Copy the full SHA
    166eddb View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed May 14, 2021
    Configuration menu
    Copy the full SHA
    43ff219 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2021

  1. Merge remote-tracking branch 'upstream/main' into add-ip-detection-ex… 

    …tension-point
    Raul Gutierrez Segales committed May 16, 2021
    Configuration menu
    Copy the full SHA
    d53e920 View commit details
    Browse the repository at this point in the history