api: relax inline_string length limitation in DataSource #14461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <[email protected]>
lizan
changed the title
esmet
reviewed
Dec 17, 2020
| } | ||
| if (!allow_empty && data.empty()) { |
There was a problem hiding this comment.
Will this start enforcing allow_empty on the kFilename case where it didn't previously?
There was a problem hiding this comment.
Yes and this is intended in that way. I took quick look on existing use and mostly are allowing empty so this shouldn't be a big issue.
htuch
reviewed
Dec 17, 2020
| @@ -334,7 +334,7 @@ message DataSource { | |||
| bytes inline_bytes = 2 [(validate.rules).bytes = {min_len: 1}]; | |||
|
|
|||
| // String inlined in the configuration. | |||
| string inline_string = 3 [(validate.rules).string = {min_len: 1}]; | |||
| string inline_string = 3; | |||
There was a problem hiding this comment.
Should we also relax on inline_bytes?
Signed-off-by: Lizan Zhou <[email protected]>
mattklein123
approved these changes
Dec 18, 2020
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Dec 22, 2020
* master: (30 commits) Deflaked: Guarddog_impl_test (envoyproxy#14475) [fuzz] add fuzz tests for hpack encoding and decoding (envoyproxy#13315) [filters] Prevent a filter from sending local reply and continue (envoyproxy#14416) oauth2: improving coverage (envoyproxy#14479) owners: Change dio email address (envoyproxy#14498) macos build: Fix ninja install (envoyproxy#14495) http: use OptRef helper to reduce some boilerplate (envoyproxy#14361) doc: update test/integration/README.md (envoyproxy#14485) server: wait workers to start before draining parent. (envoyproxy#14319) api: relax inline_string length limitation in DataSource (envoyproxy#14461) oauth: properly stop filter chain when a response was sent (envoyproxy#14476) listener: deprecate use_proxy_proto (envoyproxy#14406) deps: update cel and remove a patch (envoyproxy#14473) preconnect: rename: (envoyproxy#14474) coverage: ratcheting limits (envoyproxy#14472) grpc mux: fix sending node again after stream is reset (envoyproxy#14080) [test] Replace printers_include with printers_lib. (envoyproxy#14442) tcp: nodelay in the new pool (envoyproxy#14453) test: replace mock_methodn macros with mock_method (envoyproxy#14450) tcp: extending tcp integration test (envoyproxy#14451) ... Signed-off-by: Michael Puncel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #14276, relax the min length requirement of
inline_stringin DataSource. It should checked after DataSource since an empty file could pass validation.Risk Level: Low
Testing: integration test
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Lizan Zhou [email protected]