Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in redis doc #14248

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

ankatare
Copy link
Contributor

@ankatare ankatare commented Dec 2, 2020

Signed-off-by: Abhay Narayan Katare [email protected]

Commit Message: typo in redis configuration docs
Additional Description: see url https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/other_protocols/redis#redis-cluster-support-experimental
Risk Level: low
Testing: unit
Docs Changes: Yes
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Optional Fixes #14247
[Optional Deprecated:]

Signed-off-by: Abhay Narayan Katare <[email protected]>
@jmarantz
Copy link
Contributor

jmarantz commented Dec 3, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14248 (comment) was created by @jmarantz.

see: more, trace.

@jmarantz jmarantz self-assigned this Dec 3, 2020
@phlax
Copy link
Member

phlax commented Dec 3, 2020

this is failing vpr-litmus test in verify_examples - seems like a flake

@jmarantz
Copy link
Contributor

jmarantz commented Dec 5, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14248 (comment) was created by @jmarantz.

see: more, trace.

@ankatare
Copy link
Contributor Author

ankatare commented Dec 6, 2020

@phlax sorry, i am unable to get issue here. please suggest how to proceed.

@dio dio assigned phlax Dec 7, 2020
@mattklein123 mattklein123 merged commit cae8eab into envoyproxy:master Dec 7, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Dec 8, 2020
* master: (41 commits)
  event: Remove a source of non-determinism by always running deferred deletion before post callbacks (envoyproxy#14293)
  Fix TSAN bug in integration test (envoyproxy#14327)
  tracing: Add hostname to Zipkin config.  (envoyproxy#14186) (envoyproxy#14187)
  [conn_pool] fix use after free in H/1 connection pool (envoyproxy#14220)
  lua: update deprecated lua_open to luaL_newstate (envoyproxy#14297)
  extension: use bool_flag to control extension link (envoyproxy#14240)
  stats: Factor out creation of cluster-stats StatNames from creation of the stats, to save CPU during xDS updates (envoyproxy#14028)
  test: add scaled timer integration test (envoyproxy#14290)
  [Win32 Signals] Add term and ctrl-c signal handlers (envoyproxy#13954)
  config: v2 transport API fatal-by-default. (envoyproxy#14223)
  matcher: fix UB bug caused by dereferencing a bad optional (envoyproxy#14271)
  test: putting fake upstream config in a struct (envoyproxy#14266)
  wasm: use Bazel rules from Proxy-Wasm Rust SDK. (envoyproxy#14292)
  docs: fix typo (envoyproxy#14237)
  dependencies: allowlist CVE-2018-21270 to prevent false positives. (envoyproxy#14294)
  typo in redis doc (envoyproxy#14248)
  access_loggers: removed redundant dep (envoyproxy#14274)
  fix http2 flaky test (envoyproxy#14261)
  test: disable flaky xds_integration_test. (envoyproxy#14287)
  http: add functionality to configure kill header in KillRequest proto (envoyproxy#14288)
  ...

Signed-off-by: Michael Puncel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in redis configuration docs
4 participants