Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mention gperftools explicitly in PPROF.md #14199

Merged
merged 1 commit into from
Nov 28, 2020

Conversation

rojkov
Copy link
Member

@rojkov rojkov commented Nov 27, 2020

Commit Message: doc: mention gperftools explicitly in PPROF.md
Additional Description: Since the new default tcmalloc lacks profilers update PPROF.md to set tcmalloc=gperftools explicitly in bazel commands.
Risk Level: Low
Testing: Not needed
Docs Changes: PPROF.md updated
Release Notes: N/A
Platform Specific Features: N/A

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

As an aside, if it's possible to use any of the trace point stuff you added with perf vs. gperftools it would be great to document that also as personally I find myself always using perf and never the gperftools profile.

@mattklein123 mattklein123 merged commit 41de291 into envoyproxy:master Nov 28, 2020
@rojkov rojkov deleted the pprof-doc branch November 30, 2020 09:29
@rojkov
Copy link
Member Author

rojkov commented Nov 30, 2020

As an aside, if it's possible to use any of the trace point stuff you added with perf vs. gperftools it would be great to document that also as personally I find myself always using perf and never the gperftools profile.

Sure, the current doc seems to be outdated now and needs to be updated with other available options. Let's see what I can do...

mpuncel added a commit to mpuncel/envoy that referenced this pull request Dec 2, 2020
* master: (70 commits)
  upstream: avoid reset after end_stream in TCP HTTP upstream (envoyproxy#14106)
  bazelci: add fuzz coverage (envoyproxy#14179)
  dependencies: allowlist CVE-2020-8277 to prevent false positives. (envoyproxy#14228)
  cleanup: replace ad-hoc [0, 1] value types with UnitFloat (envoyproxy#14081)
  Update docs for skywalking tracer (envoyproxy#14210)
  Fix some errors in the switch statement when decode dubbo response (envoyproxy#14207)
  Windows: enable tests and envoy-static.exe pdb file (envoyproxy#13688)
  http: add Kill Request HTTP filter (envoyproxy#14170)
  dependencies: fix release_dates error behavior. (envoyproxy#14216)
  thrift filter: support skip decoding data after metadata in the thrift message (envoyproxy#13592)
  update cares (envoyproxy#14213)
  docs: clarify behavior of hedge_on_per_try_timeout (envoyproxy#12983)
  repokitteh: add support for randomized auto-assign. (envoyproxy#14185)
  [grpc] validate grpc config for illegal characters (envoyproxy#14129)
  server: Return nullopt when process_context is nullptr (envoyproxy#14181)
  [Windows] Fix thrift proxy tests (envoyproxy#13220)
  kafka: add missing unit tests (envoyproxy#14195)
  doc: mention gperftools explicitly in PPROF.md (envoyproxy#14199)
  Removed `--use-fake-symbol-table` option. (envoyproxy#14178)
  filter contract: clarification around local replies (envoyproxy#14193)
  ...

Signed-off-by: Michael Puncel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants