Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump Bazel to 3.7.0 #14123

Closed

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Nov 20, 2020

Commit Message: Bump Bazel to 3.7.0
Additional Description: Build container bumps MSVC toolchain for Windows, helps us move forward to enable clang-cl which requires LLVM 11.0.0 (requires a bug fix backported to Bazel 3.7.1 and in 4.0.0)
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Sunjay Bhatia <[email protected]>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 20, 2020
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #14123 was opened by sunjayBhatia.

see: more, trace.

@sunjayBhatia sunjayBhatia requested review from lizan and moderation and removed request for lizan November 20, 2020 18:58
@sunjayBhatia sunjayBhatia changed the title Bump Bazel to 3.7.0 build: Bump Bazel to 3.7.0 Nov 20, 2020
@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 20, 2020
@lizan
Copy link
Member

lizan commented Nov 20, 2020

coverage differences in test/common/network

master: https://storage.googleapis.com/envoy-postsubmit/master/coverage/source/common/network/socket_impl.cc.gcov.html

PR: https://storage.googleapis.com/envoy-pr/9f7beaf/coverage/source/common/network/socket_impl.cc.gcov.html

I've seen same in different PR as well, might not related to the bump but might be some flakes (and being cached)

@wrowe
Copy link
Contributor

wrowe commented Nov 21, 2020

@sunjayBhatia is taking the entire week, but I'm available to tweak commits, or you can do so yourself.

My 2c, let's take this if it is convenient before Tuesday, just to have greater confidence in the 3.7.1 bump.

@lizan
Copy link
Member

lizan commented Nov 22, 2020

all fuzz_coverage tests are failing and it's obviously broken, so we need to fix that and I don't think it will be fixed in 3.7.1 either.

@wrowe
Copy link
Contributor

wrowe commented Nov 23, 2020

we need to fix that and I don't think it will be fixed in 3.7.1 either

Have you identified this as bazel's or envoy's defect, @lizan? There's still a window today to note the regression at bazelbuild/bazel#12188 if this represents a 3.6.0 regression.

@sunjayBhatia
Copy link
Member Author

Bumps to Bazel 3.7+ are blocked on bazelbuild/bazel#12545

@sunjayBhatia
Copy link
Member Author

closing in favor of #14134, though we will need a 3.7.2 to fix the regression reported in bazelbuild/bazel#12545

@sunjayBhatia sunjayBhatia deleted the bump-bazel-3.7.0 branch December 1, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants