Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove shellcheck diff flag #13560

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 14, 2020

Signed-off-by: Ryan Northey [email protected]

Commit Message: ci: Remove shellcheck diff flag
Additional Description:

Using this flag suppresses output on most code problems, as they are not auto-fixable.

Instead all you see is

Issues were detected, but none were auto-fixable. Use another format to see them.

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

@phlax phlax changed the title ci: Remove shellcheck diff ci: Remove shellcheck diff flag Oct 14, 2020
@phlax
Copy link
Member Author

phlax commented Oct 14, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13560 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Oct 14, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13560 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Oct 14, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13560 (comment) was created by @phlax.

see: more, trace.

htuch
htuch previously approved these changes Oct 14, 2020
@htuch htuch self-assigned this Oct 14, 2020
@phlax
Copy link
Member Author

phlax commented Oct 14, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13560 (comment) was created by @phlax.

see: more, trace.

Signed-off-by: Ryan Northey <[email protected]>
@mattklein123 mattklein123 merged commit 7d64bb9 into envoyproxy:master Oct 15, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 15, 2020
* master:
  ci: use multiple stage (envoyproxy#13557)
  tls: update BoringSSL to 2192bbc8 (4240). (envoyproxy#13567)
  fix macos v8 build (envoyproxy#13572)
  Fixed Health Check Fuzz corpus syntax (envoyproxy#13576)
  ci: Remove shellcheck diff (envoyproxy#13560)
  ci: Increate brew retry interval (envoyproxy#13565)
  dependencies: fix some of the fallout from Wasm merge. (envoyproxy#13569)
  hds: add support for delta updates in specifier (envoyproxy#13067)
  ci: workaround for actions/runner-images#1811 (envoyproxy#13577)
  ratelimit: be able to disable x-envoy-ratelimited response header sent (envoyproxy#13270)
  Update opencensus library (envoyproxy#13549)
  ci: use azp for api and go-control-plane sync (envoyproxy#13550)
  docs: Remove/make generic lyft references in docs (envoyproxy#13559)
  check_format: adding 2 more release note checks (envoyproxy#13444)
  [Wasm] Add cluster metadata fallback and upstream host metadata (envoyproxy#13477)
  [fuzz] Added validation for secrets (envoyproxy#13543)
  Add Platform Specific Feature guidance to PR template (envoyproxy#13547)

Signed-off-by: Michael Puncel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants