Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bring BAZEL_BUILD_OPTIONS back for format and docs #13480

Merged
merged 3 commits into from
Oct 11, 2020
Merged

ci: bring BAZEL_BUILD_OPTIONS back for format and docs #13480

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e890275
ci: bring BAZEL_BUILD_OPTIONS back for format and docs
lizan Oct 10, 2020
9b3a434
disable SC2178
lizan Oct 10, 2020
3309f84
pass to proto_format only
lizan Oct 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ci/do_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,21 +369,23 @@ elif [[ "$CI_TARGET" == "bazel.fuzz" ]]; then
elif [[ "$CI_TARGET" == "fix_format" ]]; then
# proto_format.sh needs to build protobuf.
setup_clang_toolchain

echo "fix_format..."
./tools/code_format/check_format.py fix
./tools/code_format/format_python_tools.sh fix
./tools/proto_format/proto_format.sh fix --test
BAZEL_BUILD_OPTIONS="${BAZEL_BUILD_OPTIONS[*]}" ./tools/proto_format/proto_format.sh fix --test
exit 0
elif [[ "$CI_TARGET" == "check_format" ]]; then
# proto_format.sh needs to build protobuf.
setup_clang_toolchain

echo "check_format_test..."
./tools/code_format/check_format_test_helper.sh --log=WARN
echo "check_format..."
./tools/code_format/check_shellcheck_format.sh
./tools/code_format/check_format.py check
./tools/code_format/format_python_tools.sh check
./tools/proto_format/proto_format.sh check --test
BAZEL_BUILD_OPTIONS="${BAZEL_BUILD_OPTIONS[*]}" ./tools/proto_format/proto_format.sh check --test
exit 0
elif [[ "$CI_TARGET" == "check_repositories" ]]; then
echo "check_repositories..."
Expand Down Expand Up @@ -411,7 +413,7 @@ elif [[ "$CI_TARGET" == "docs" ]]; then
tools/dependency/validate_test.py
tools/dependency/validate.py
# Build docs.
docs/build.sh
BAZEL_BUILD_OPTIONS="${BAZEL_BUILD_OPTIONS[*]}" docs/build.sh
exit 0
elif [[ "$CI_TARGET" == "verify_examples" ]]; then
echo "verify examples..."
Expand Down