dependencies: associate extensions with deps, validate use_category. #13340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a few related changes: * use_category is restructured to distinguish core/extension deps. There's also an extension allowlist added for each dependency in the dataplane_ext and observability_ext category. * tools/dependency/validate.py is introduced to validate a bunch of structural relationships implied by the bazel/repository_locations.bzl metadata. This includes that test-only deps aren't used in //source/.., that some obvious dataplane/controlplane packages taint the appropriate reachable deps and that the association between extensions/deps holds. * The CI docs jobs now runs tools/dependency/validate.py. * The dependency dashboard at https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/security/external_deps to include granular information on which dataplane/observability deps come from core/extensions. * Some misc. cleanup of source code dep that came up while working on this. Risk level: Low Testing: Pyunit tests added for validate.py. Part of envoyproxy#12673. Signed-off-by: Harvey Tuch <[email protected]>
htuch
requested review from
alyssawilk,
lizan and
mattklein123
as code owners
htuch
requested review from
moderation and
phlax
and removed request for
lizan and
alyssawilk
moderation
reviewed
Sep 30, 2020
moderation
reviewed
Sep 30, 2020
|
LGTM - as discussed in Slack I'll PR my changes to the API dependencies so we can bring them into the docs output too |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
mattklein123
requested changes
Oct 1, 2020
phlax
reviewed
Oct 1, 2020
phlax
reviewed
Oct 1, 2020
phlax
reviewed
Oct 1, 2020
phlax
reviewed
Oct 1, 2020
phlax
reviewed
Oct 1, 2020
phlax
reviewed
Oct 1, 2020
phlax
reviewed
Oct 1, 2020
phlax
reviewed
Oct 1, 2020
phlax
reviewed
Oct 1, 2020
phlax
reviewed
Oct 1, 2020
|
@htuch ive left a mostly python style/formatting review, as im only just becoming familiar with the code here. the output looks very useful |
Signed-off-by: Harvey Tuch <[email protected]>
phlax
reviewed
Oct 1, 2020
mattklein123
previously approved these changes
Oct 1, 2020
Signed-off-by: Harvey Tuch <[email protected]>
mattklein123
approved these changes
Oct 1, 2020
yanavlasov
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few related changes:
use_category is restructured to distinguish core/extension deps. There's also an extension
allowlist added for each dependency in the dataplane_ext and observability_ext category.
tools/dependency/validate.py is introduced to validate a bunch of structural relationships
implied by the bazel/repository_locations.bzl metadata. This includes that test-only deps
aren't used in //source/.., that some obvious dataplane/controlplane packages taint the
appropriate reachable deps and that the association between extensions/deps holds.
The CI docs job now runs tools/dependency/validate.py.
The dependency dashboard at
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/security/external_deps
to include granular information on which dataplane/observability deps come from core/extensions.
Some misc. cleanup of source code dep that came up while working on this.
Risk level: Low
Testing: Pyunit tests added for validate.py.
Part of #12673.
Signed-off-by: Harvey Tuch [email protected]