Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: kick-off 1.12.7 release. #12163

Merged
merged 1 commit into from
Jul 20, 2020
Merged

docs: kick-off 1.12.7 release. #12163

merged 1 commit into from
Jul 20, 2020

Conversation

PiotrSikora
Copy link
Contributor

Signed-off-by: Piotr Sikora [email protected]

@PiotrSikora
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PiotrSikora
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PiotrSikora
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

lambdai
lambdai approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@lambdai lambdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lambdai
Copy link
Contributor

lambdai commented Jul 20, 2020

/assign lizan

@PiotrSikora
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lizan
Copy link
Member

lizan commented Jul 20, 2020

Can you cherry-pick #9140 #10496 #10818 to fix clang_tidy and macOS CI?

@lizan lizan merged commit b681c4f into envoyproxy:release/v1.12 Jul 20, 2020
@PiotrSikora
Copy link
Contributor Author

Can you cherry-pick #9140 #10496 #10818 to fix clang_tidy and macOS CI?

@lambdai is now maintaining the stable releases... You could also cherry-pick them yourself ;)

But both clang_tidy and macOS are working fine (although, a bit flaky), since they passed in #12167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdai lambdai lambdai approved these changes

@lizan lizan Awaiting requested review from lizan

Assignees

@lambdai lambdai

@lizan lizan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PiotrSikora @lambdai @lizan