preliminary PR to Porting Envoy to C++17 #11840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yifan Yang <[email protected]>
Signed-off-by: Yifan Yang <[email protected]>
|
@stedsome It is not quite clear from the description, if this is a draft PR or you are ready to review and merge it. I could be deja vu, but I think I have already reviewed it. |
|
@yanavlasov yes you are not mistaken. This is a duplicate of what you have seen before. It is just because I wasn't able to reproduce the failed tests in CI so I resubmitted this. It turns out that the tests that are failed are actually different this time. I don't know what should I make of that |
|
@yanavlasov do you mind merging this for me if everything looks good? This is ready for submission. |
|
@yanavlasov Hey, just want to make sure you did see my previous message |
yanavlasov
approved these changes
Jul 7, 2020
jwendell
pushed a commit
to istio/envoy
that referenced
this pull request
Jul 21, 2020
* Revert "test: shard http2_integration_test (envoyproxy#11939)" This reverts commit 2026ec2. * Revert "fuzz: added fuzz test for listener filter original_dst (envoyproxy#11847)" This reverts commit 673cab8. * Revert "docs: updating release instructions (envoyproxy#11938)" This reverts commit 09b96a5. * Revert "test: remove superfluous test dependencies (envoyproxy#11912)" This reverts commit 5e9fb8a. * Revert "dynamic_forward_proxy: cleanup integration test (envoyproxy#11891)" This reverts commit 11a4667. * Revert "preliminary PR to Porting Envoy to C++17 (envoyproxy#11840)" This reverts commit 9ad964d. * Revert "connection: Do not reset delayed closed timer if doWrite consumes 0 bytes from the output buffer. (envoyproxy#11833)" This reverts commit 5960533. * Revert "threadlocal: avoiding a dynamic cast in opt builds (envoyproxy#11900)" This reverts commit 363b104. * Revert "release: kicking off 1.16.0 (envoyproxy#11930)" This reverts commit ef74d8f. Signed-off-by: Lizan Zhou <[email protected]>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
This is the PR that does the setup work needed to fix some incompatiblity issue with the current codebase and C++17. This is a part of the draft PR envoyproxy#11570 that intends to port Envoy to C++17, sans all the changes to build configurations. Signed-off-by: Yifan Yang [email protected] Signed-off-by: scheler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR that does the setup work needed to fix some
incompatiblity issue with the current codebase and C++17.
This is a part of the draft PR #11570 that intends to
port Envoy to C++17, sans all the changes to build configurations.
Signed-off-by: Yifan Yang [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]