Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns cache: add dns failure refresh rate #10200

Merged
merged 21 commits into from
Feb 29, 2020
Merged

dns cache: add dns failure refresh rate #10200

merged 21 commits into from
Feb 29, 2020

Conversation

junr03
Copy link
Member

@junr03 junr03 commented Feb 28, 2020

Description: add dns_failure_refresh_rate to the dns cache, much like the strict and logical dns clusters.
Risk Level: low. New functionality needs a config change to opt in.
Testing: Added unit tests.
Docs Changes: updated
Release Notes: added entry

Adds functionality needed by envoyproxy/envoy-mobile#673

Jose Nino added 20 commits February 21, 2020 15:28
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
fmt
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
wip
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
fmt
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10200 was opened by junr03.

see: more, trace.

@junr03 junr03 changed the title [Draft]: add dns failure refresh to the Dns Cache dns cache: add dns failure refresh rate Feb 28, 2020
@junr03 junr03 marked this pull request as ready for review February 28, 2020 22:39
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@mattklein123 mattklein123 merged commit 4e5e1fb into envoyproxy:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants