Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holistic approach to WAF #7918

Open
mattklein123 opened this issue Aug 14, 2019 · 7 comments
Open

Holistic approach to WAF #7918

mattklein123 opened this issue Aug 14, 2019 · 7 comments
Assignees
Labels
design proposal Needs design doc/proposal before implementation enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@mattklein123
Copy link
Member

In the wake of the recent CVEs, it's become more clear that we need a holistic approach to WAF, primarily allowing for both blocking, blackholing, etc. both L4 and L7 traffic based on various input parameters.

We have various bits and pieces of this today including RBAC, IP tagging, but we need to look through the type of blocking actions that users want to perform and likely build explicit L4 and L7 WAF filters. We also need to think about how these filters would be dynamically populated with block rules via config, streaming API, etc.

@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. design proposal Needs design doc/proposal before implementation help wanted Needs help! labels Aug 14, 2019
@mattklein123 mattklein123 added this to the 1.14.0 milestone Dec 13, 2019
@mattklein123 mattklein123 modified the milestones: 1.14.0, 1.15.0 Mar 10, 2020
@kprakasam
Copy link
Contributor

@gkleiman I thought I messaged you about working on this, seems I did not, can you let me know when you have sometime so we can coordinate work on this and #10207.

@kprakasam
Copy link
Contributor

@mattklein123
Copy link
Member Author

Sorry for the long delay. At a high level this LGTM. My preference would be to start with a config proto only PR and we can discuss further there?

kprakasam added a commit to kprakasam/envoy that referenced this issue Jun 1, 2020
@mattklein123 mattklein123 modified the milestones: 1.15.0, 1.16.0 Jun 17, 2020
@mattklein123 mattklein123 self-assigned this Aug 11, 2020
@mattklein123 mattklein123 modified the milestones: 1.16.0, 1.17.0 Oct 4, 2020
@mattklein123 mattklein123 self-assigned this Dec 7, 2020
@mattklein123 mattklein123 modified the milestones: 1.17.0, 1.18.0 Jan 7, 2021
@mattklein123 mattklein123 modified the milestones: 1.18.0, 1.19.0 Apr 25, 2021
@mattklein123 mattklein123 removed this from the 1.19.0 milestone Jul 7, 2021
@mattklein123 mattklein123 added this to the 1.20.0 milestone Jul 7, 2021
@alyssawilk alyssawilk modified the milestones: 1.20.0, 1.21.0 Oct 4, 2021
@alyssawilk alyssawilk modified the milestones: 1.21.0, 1.22.0 Jan 10, 2022
@mattklein123 mattklein123 removed this from the 1.22.0 milestone Apr 12, 2022
@mattklein123 mattklein123 removed their assignment Jul 19, 2022
@agrawroh
Copy link
Contributor

agrawroh commented Sep 3, 2022

@mattklein123 Is there any progress being made on this? The PR seems to have staled out. We could use WAF in our ingress deployment and would be wiling to contribute.

@mattklein123
Copy link
Member Author

None that I know of. I think the folks at Reblaze/Curiefense are still theoretically working on this but I haven't seen any traction. Basically I would like to just do a filter that relies on generic matching that can apply various WAF like actions (tar pit, etc.).

@arkodg
Copy link
Contributor

arkodg commented Nov 10, 2022

Stopping by to say that It would be great if there was a native filter implementation for WAF !
Envoy Gateway would like to support WAF and the first iteration is considering providing the functionality using a WASM module envoyproxy/gateway#671

@mattklein123
Copy link
Member Author

I'm in favor of the OWASP approach now that I have learned more about it. My main concerns involve the reliance on WASM due to:

  1. Performance
  2. The fact that WASM is still considered alpha in Envoy and recent investment appears to be limited.

We will need to reconcile both of the above moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design proposal Needs design doc/proposal before implementation enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

6 participants