Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update verify_subject_alt_name from string to array #515

Closed
wattli opened this issue Feb 27, 2017 · 1 comment · Fixed by #559
Closed

Update verify_subject_alt_name from string to array #515

wattli opened this issue Feb 27, 2017 · 1 comment · Fixed by #559
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@wattli
Copy link
Contributor

wattli commented Feb 27, 2017

To make it more generic for more feature support.
@wattli
Copy link
Contributor Author

wattli commented Feb 27, 2017

And I am working on it.

@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Mar 3, 2017
@myidpt myidpt mentioned this issue Mar 11, 2017
Merged
lizan pushed a commit to lizan/envoy that referenced this issue Jun 4, 2020
@jplevyak
Add stats for wasm remote load fetch and cache. (envoyproxy#515)
ee990c9 
(Backport from istio/envoy release-1.6)

Signed-off-by: John Plevyak <[email protected]>
jpsim pushed a commit that referenced this issue Nov 28, 2022
@rebello95 @jpsim
swift: handle gRPC compression errors (#515)
848fc73 
Updates the Swift gRPC response compression error handling logic to match Android's:
- Instead of silently failing, call `onError` in a terminal state and clear out other callbacks
- Retain the `GRPCResponseHandler` while the core Envoy engine retains the underlying `onData` callback to ensure that error and message propogation can be called by the handler

Context: envoyproxy/envoy-mobile#472 (comment)

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@rebello95 @jpsim
swift: handle gRPC compression errors (#515)
d8a854b 
Updates the Swift gRPC response compression error handling logic to match Android's:
- Instead of silently failing, call `onError` in a terminal state and clear out other callbacks
- Retain the `GRPCResponseHandler` while the core Envoy engine retains the underlying `onData` callback to ensure that error and message propogation can be called by the handler

Context: envoyproxy/envoy-mobile#472 (comment)

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify SAN with multiple values, support verifying URI type in SAN myidpt/envoy
2 participants
@mattklein123 @wattli