envoy_reloadable_features_grpc_http1_reverse_bridge_change_http_status deprecation #35368
Labels
deprecation
Feature deprecation tracking
no stalebot
Disables stalebot from closing an issue
tech debt
Comments
alyssawilk
added
deprecation
hq6
added a commit
to hq6/envoy
that referenced
this issue
Jul 23, 2024
This commit removes the runtime flag introduced in envoyproxy#31047 since it has been 6 months since that change. Signed-off-by: Henry Qin <[email protected]>
|
I will put up a PR for this one after my previous cleanup PR is merged, unless you'd prefer that I put both cleanups in the same PR. |
|
one at a time is fine, thanks! |
hq6
added a commit
to hq6/envoy
that referenced
this issue
Jul 25, 2024
This commit removes the runtime flag introduced in envoyproxy#31047 since it has been 6 months since that change. Signed-off-by: Henry Qin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Your change #31047 (Make grpc_http1_reverse_bridge return HTTP 200.) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
cc @hq6
The text was updated successfully, but these errors were encountered: