Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/remove opentracing lib #27401

Closed
phlax opened this issue May 15, 2023 · 16 comments · Fixed by #35418
Closed

Deprecate/remove opentracing lib #27401

phlax opened this issue May 15, 2023 · 16 comments · Fixed by #35418
Labels
area/extension area/tracing dependencies Pull requests that update a dependency file deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue

Comments

@phlax
Copy link
Member

phlax commented May 15, 2023

There has been the intention to remove this lib for some time

There were some issues with the build, but #27400 fixes it for now so we can retain and deprecate properly

@phlax phlax added deprecation Feature deprecation tracking dependencies Pull requests that update a dependency file labels May 15, 2023
@phlax
Copy link
Member Author

phlax commented May 15, 2023

cc @moderation @Oberon00 @kyessenov

@phlax
Copy link
Member Author

phlax commented May 15, 2023

related to #9958

@RiverPhillips
Copy link
Contributor

Before we deprecate existing tracers is it possible to clarify the security posture of OpenTelemetry? #24672

@Oberon00
Copy link
Contributor

Oberon00 commented May 16, 2023

It would also be cool if envoy could support OpenTelemetry OTLP over HTTP (in addition to the current gRPC) before that, see also #9958 (comment)

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 15, 2023
@phlax phlax added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Jun 15, 2023
@yanavlasov
Copy link
Contributor

Before we deprecate existing tracers is it possible to clarify the security posture of OpenTelemetry? #24672

The security posture has been changed to unknown since there the upstream OT repository is frozen.

@Oberon00
Copy link
Contributor

Hi, just to confirm, in the current main branch, before 1.29 is cut, the hard deprecation will happen where an override is required to still access the functionality?

@Oberon00
Copy link
Contributor

@RyanTheOptimist @phlax At the moment at Dynatrace we are making plans assuming the hard deprecation is merged in 1.29, can you confirm this is actually planned?

This matters for Dynatrace because we need special handling for the version(s) where the config option causes startup to abort without the deprecation override but OpenTracing is still detectable in the binary. As long as >=1.30 actually has OpenTracing removed completely from the binary, that will be fine, but if that version slips due to not adding a hard deprecation in 1.29 we would need to make adjustments.

@joaopgrassi
Copy link
Contributor

@wbpcode do you maybe know anything about the above?

@phlax
Copy link
Member Author

phlax commented Dec 5, 2023

can you confirm this is actually planned?

afaiaa this is planned and i think messaging was sent out to this effect altho i think most likely it will be after 1.29 is cut

@joaopgrassi
Copy link
Contributor

@phlax

afaiaa this is planned and i think messaging was sent out to this effect altho i think most likely it will be after 1.29 is cut

Alright so, reading https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features and https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md#breaking-change-policy I understand the deprecation cycle as follows:

  • First phase: mark as deprecated (✅ done in 1.28)
  • Second phase: Disallow feature by default, by adding the disallowed_by_default annotation (❌ not done yet on main thus not part of 1.29)
  • Third phase: Remove the fields completely (1.30?)

Is my understanding right? If so, that means phase two will be 1.30 and phase three 1.31?

@phlax
Copy link
Member Author

phlax commented Jan 8, 2024

@joaopgrassi this seems correct to me - but seeing as we are slipping a version can we prioritize adding the deprecation as soon as 1.29 is cut?

@joaopgrassi
Copy link
Contributor

joaopgrassi commented Jan 8, 2024

but seeing as we are slipping a version can we prioritize adding the deprecation as soon as 1.29 is cut?

@phlax This means then the disallowed_by_default behavior would only be enforced on 1.30? That seems totally fine. Would be great also for us at Dynatrace and our customers.

@phlax
Copy link
Member Author

phlax commented Jan 8, 2024

i think that is fine, as long as we prioritize the deprecation soon after release

@joaopgrassi
Copy link
Contributor

i think that is fine, as long as we prioritize the deprecation soon after release

Sounds good to me!

@alyssawilk
Copy link
Contributor

ok deprecation went through, and we're a couple releases past the original warning point so I plan on removing this soon.
Please let me know if there are any remaining concerns.

alyssawilk added a commit that referenced this issue Jul 29, 2024
Risk Level: medium
Testing: n/a
Docs Changes:
Release Notes: inline
Fixes #27401
Fixes #34321

---------

Signed-off-by: Alyssa Wilk <[email protected]>
update-envoy bot added a commit to envoyproxy/data-plane-api that referenced this issue Jul 29, 2024
Risk Level: medium
Testing: n/a
Docs Changes:
Release Notes: inline
Fixes envoyproxy/envoy#27401
Fixes envoyproxy/envoy#34321

---------

Signed-off-by: Alyssa Wilk <[email protected]>

Mirrored from https://github.com/envoyproxy/envoy @ a6848603acf28017f9194789b01d16c6c1782e3e
martinduke pushed a commit to martinduke/envoy that referenced this issue Aug 8, 2024
Risk Level: medium
Testing: n/a
Docs Changes:
Release Notes: inline
Fixes envoyproxy#27401
Fixes envoyproxy#34321

---------

Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Martin Duke <[email protected]>
asingh-g pushed a commit to asingh-g/envoy that referenced this issue Aug 20, 2024
Risk Level: medium
Testing: n/a
Docs Changes:
Release Notes: inline
Fixes envoyproxy#27401
Fixes envoyproxy#34321

---------

Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: asingh-g <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extension area/tracing dependencies Pull requests that update a dependency file deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue
Projects
None yet
6 participants