-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate/remove opentracing lib #27401
Comments
related to #9958 |
Before we deprecate existing tracers is it possible to clarify the security posture of OpenTelemetry? #24672 |
It would also be cool if envoy could support OpenTelemetry OTLP over HTTP (in addition to the current gRPC) before that, see also #9958 (comment) |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
The security posture has been changed to |
Hi, just to confirm, in the current main branch, before 1.29 is cut, the hard deprecation will happen where an override is required to still access the functionality? |
@RyanTheOptimist @phlax At the moment at Dynatrace we are making plans assuming the hard deprecation is merged in 1.29, can you confirm this is actually planned? This matters for Dynatrace because we need special handling for the version(s) where the config option causes startup to abort without the deprecation override but OpenTracing is still detectable in the binary. As long as >=1.30 actually has OpenTracing removed completely from the binary, that will be fine, but if that version slips due to not adding a hard deprecation in 1.29 we would need to make adjustments. |
@wbpcode do you maybe know anything about the above? |
afaiaa this is planned and i think messaging was sent out to this effect altho i think most likely it will be after 1.29 is cut |
Alright so, reading https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features and https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md#breaking-change-policy I understand the deprecation cycle as follows:
Is my understanding right? If so, that means phase two will be |
@joaopgrassi this seems correct to me - but seeing as we are slipping a version can we prioritize adding the deprecation as soon as 1.29 is cut? |
@phlax This means then the |
i think that is fine, as long as we prioritize the deprecation soon after release |
Sounds good to me! |
ok deprecation went through, and we're a couple releases past the original warning point so I plan on removing this soon. |
Risk Level: medium Testing: n/a Docs Changes: Release Notes: inline Fixes #27401 Fixes #34321 --------- Signed-off-by: Alyssa Wilk <[email protected]>
Risk Level: medium Testing: n/a Docs Changes: Release Notes: inline Fixes envoyproxy/envoy#27401 Fixes envoyproxy/envoy#34321 --------- Signed-off-by: Alyssa Wilk <[email protected]> Mirrored from https://github.com/envoyproxy/envoy @ a6848603acf28017f9194789b01d16c6c1782e3e
Risk Level: medium Testing: n/a Docs Changes: Release Notes: inline Fixes envoyproxy#27401 Fixes envoyproxy#34321 --------- Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: Martin Duke <[email protected]>
Risk Level: medium Testing: n/a Docs Changes: Release Notes: inline Fixes envoyproxy#27401 Fixes envoyproxy#34321 --------- Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: asingh-g <[email protected]>
There has been the intention to remove this lib for some time
There were some issues with the build, but #27400 fixes it for now so we can retain and deprecate properly
The text was updated successfully, but these errors were encountered: