Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression test QUIC crash caused by the import #16234

Closed
alyssawilk opened this issue Apr 29, 2021 · 5 comments · Fixed by #16260
Closed

regression test QUIC crash caused by the import #16234

alyssawilk opened this issue Apr 29, 2021 · 5 comments · Fixed by #16260
Assignees
@DavidSchinazi
Labels
bug quic-mvp Required for QUIC MVP

Comments

@alyssawilk
Copy link
Contributor

See discussion on #16100 (h/t @moderation for discovery)
@DavidSchinazi
Copy link
Contributor

Thanks for filing. I'll take care of this.

@alyssawilk
Copy link
Contributor Author

Awesome, thanks!

@DavidSchinazi
Copy link
Contributor

I'm able to reproduce the crash at 58a1357 (from 2021-04-23) but not at 82e33f6 (from today 2021-04-29). @moderation could you please try again on tip of tree with your setup to confirm whether this is fixed?

@moderation
Copy link
Contributor

I can't reproduce now either. I did try this morning after #15912 but before #16151 and was able to crash. But now everything looks good! Thanks

@DavidSchinazi
Copy link
Contributor

Thanks! Let's keep this issue open to track the addition of a regression test, but it looks like we resolved the crash.

@DavidSchinazi DavidSchinazi mentioned this issue Apr 30, 2021
Merged
@alyssawilk alyssawilk changed the title Fix QUIC crash caused by the lates timport regression test QUIC crash caused by the import May 3, 2021
@alyssawilk alyssawilk added quic-mvp Required for QUIC MVP and removed quic-alpha labels May 3, 2021
alyssawilk pushed a commit that referenced this issue May 5, 2021
@DavidSchinazi
quic: add support for client-side QUIC 0-RTT (#16260)
691487d 
This PR introduces EnvoyQuicSessionCache, which is responsible
for saving QUIC+TLS session tickets which are required for 0-RTT.

Risk Level: Low
Testing: unit tests, integration test
Docs Changes: None
Release Notes: None
Platform Specific Features: None

Closes #16234

Signed-off-by: David Schinazi <[email protected]>
gokulnair pushed a commit to gokulnair/envoy that referenced this issue May 6, 2021
@DavidSchinazi
quic: add support for client-side QUIC 0-RTT (envoyproxy#16260)
7eae147 
This PR introduces EnvoyQuicSessionCache, which is responsible
for saving QUIC+TLS session tickets which are required for 0-RTT.

Risk Level: Low
Testing: unit tests, integration test
Docs Changes: None
Release Notes: None
Platform Specific Features: None

Closes envoyproxy#16234

Signed-off-by: David Schinazi <[email protected]>
Signed-off-by: Gokul Nair <[email protected]>
gokulnair pushed a commit to gokulnair/envoy that referenced this issue May 6, 2021
@DavidSchinazi
quic: add support for client-side QUIC 0-RTT (envoyproxy#16260)
318c4dc 
This PR introduces EnvoyQuicSessionCache, which is responsible
for saving QUIC+TLS session tickets which are required for 0-RTT.

Risk Level: Low
Testing: unit tests, integration test
Docs Changes: None
Release Notes: None
Platform Specific Features: None

Closes envoyproxy#16234

Signed-off-by: David Schinazi <[email protected]>
Signed-off-by: Gokul Nair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidSchinazi DavidSchinazi

Labels
bug quic-mvp Required for QUIC MVP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for client-side QUIC 0-RTT DavidSchinazi/envoy
3 participants
@moderation @DavidSchinazi @alyssawilk