Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua filter: Expose streamInfo::requestedServerName() #15142

Closed
sunjayBhatia opened this issue Feb 22, 2021 · 2 comments · Fixed by #15215
Closed

Lua filter: Expose streamInfo::requestedServerName() #15142

sunjayBhatia opened this issue Feb 22, 2021 · 2 comments · Fixed by #15215
Assignees
Labels
area/lua enhancement Feature requests. Not bugs or questions.

Comments

@sunjayBhatia
Copy link
Member

Description:
The Lua filter currently allows access to the "stream info" on a request which exposes a few helpful pieces of information (docs here) including the request protocol, downstream address, etc. Another useful piece of information in the stream info API is the requested server name (for SNI). It would be useful to expose this so users can do some inspection of the requested server name (see link below) or other use cases. This field is allowed as a variable in access logs/dynamic header values already and would be useful to add access in the Lua filter as well.

Relevant Links:

  • Related to project Contour attempting to solve Envoy does not adhere to HTTP/2 RFC 7540 #6767 but it could be useful outside of that context as well
    • Specifically needed when we have a filter chain/routes that match a wildcard domain *.foo.com and want to verify the requested server and :authority match
@sunjayBhatia sunjayBhatia added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 22, 2021
@sunjayBhatia
Copy link
Member Author

Happy to put up a PR for this myself, but figured an issue would be better first

@snowp
Copy link
Contributor

snowp commented Feb 23, 2021

Sure, I see no problem with exposing this information.

@snowp snowp removed the triage Issue requires triage label Feb 23, 2021
sunjayBhatia added a commit to sunjayBhatia/envoy that referenced this issue Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lua enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants