Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired SSL cert on 3rd party mirror - Kafka #13011

Closed
murray-stripe opened this issue Sep 8, 2020 · 3 comments · Fixed by #13025
Closed

Expired SSL cert on 3rd party mirror - Kafka #13011

murray-stripe opened this issue Sep 8, 2020 · 3 comments · Fixed by #13025
Labels

Comments

@murray-stripe
Copy link
Contributor

Title: Expired SSL cert on mirror - external dependency - kafka

Description:

The download mirror for the kafka dependency seems to have an expired certificate and from-source builds are not currently possible with an empty bazel cache.

There may not actually be any resolution to this from the Envoy project's side, but creating the ticket for posterity and to note for the maintainers.

Error from browser when attemping to access the Kafka download:
image

Repro steps:

bazelisk clean --expunge
bazelisk build //...
@murray-stripe murray-stripe added bug triage Issue requires triage labels Sep 8, 2020
@akonradi
Copy link
Contributor

akonradi commented Sep 8, 2020

I don't see that mirror listed on this Apache mirrors list. This health status probe page also shows it has been unavailable for a while.

@moderation
Copy link
Contributor

moderation commented Sep 8, 2020

Looks like we should switch to the suggested mirror https://mirrors.gigenet.com/apache/kafka/2.4.1/kafka_2.12-2.4.1.tgz

    kafka_server_binary = dict(
        project_name = "Kafka (server binary)",
        project_url = "https://kafka.apache.org",
        version = "2.4.1",
        sha256 = "2177cbd14118999e1d76fec628ca78ace7e6f841219dbc6035027c796bbe1a2a",
        strip_prefix = "kafka_2.12-{version}",
        urls = ["https://mirrors.gigenet.com/apache/kafka/{version}/kafka_2.12-{version}.tgz"],
        use_category = ["test"],
    ),

@htuch htuch removed the triage Issue requires triage label Sep 9, 2020
@htuch
Copy link
Member

htuch commented Sep 9, 2020

Agreed, let's just switch mirror, would you be able to submit a PR? Thanks.

htuch pushed a commit that referenced this issue Sep 9, 2020
Update mirror used to fetch kafka dependency to a valid, working mirror.

Resolves #13011

Risk Level: low
Testing: covered by CI

Signed-off-by: John Murray <[email protected]>
antoniovicente added a commit to antoniovicente/envoy that referenced this issue Sep 25, 2020
Update mirror used to fetch kafka dependency to a valid, working mirror.

Based on envoyproxy#13025
Resolves envoyproxy#13011

Signed-off-by: Antonio Vicente <[email protected]>
antoniovicente added a commit to antoniovicente/envoy that referenced this issue Sep 28, 2020
Update mirror used to fetch kafka dependency to a valid, working mirror.

Based on envoyproxy#13025
Resolves envoyproxy#13011

Signed-off-by: Antonio Vicente <[email protected]>
antoniovicente added a commit to antoniovicente/envoy that referenced this issue Sep 28, 2020
Update mirror used to fetch kafka dependency to a valid, working mirror.

Based on envoyproxy#13025
Resolves envoyproxy#13011

Signed-off-by: Antonio Vicente <[email protected]>
mattklein123 pushed a commit that referenced this issue Sep 29, 2020
Update mirror used to fetch kafka dependency to a valid, working mirror.

Based on #13025
Resolves #13011

Signed-off-by: Antonio Vicente <[email protected]>
mattklein123 pushed a commit that referenced this issue Sep 29, 2020
Update mirror used to fetch kafka dependency to a valid, working mirror.

Based on #13025
Resolves #13011

Signed-off-by: Antonio Vicente <[email protected]>
mattklein123 pushed a commit that referenced this issue Sep 29, 2020
Update mirror used to fetch kafka dependency to a valid, working mirror.

Based on #13025
Resolves #13011

Signed-off-by: Antonio Vicente <[email protected]>
istio-testing pushed a commit to istio/envoy that referenced this issue Jan 8, 2021
* docs: kick-off 1.15.1 release. (envoyproxy#12166)

Signed-off-by: Piotr Sikora <[email protected]>

* tls: update BoringSSL-FIPS to 20190808. (envoyproxy#12170)

Signed-off-by: Piotr Sikora <[email protected]>

* test: Exclude wasm_vm_test from CI by making it a "manual" test. (#207)

The wee v8 build times out in CI under --config=asan because the machine the job is scheduled on is too small.

Signed-off-by: Antonio Vicente <[email protected]>

* [v1.15] http: header map security fixes for duplicate headers (#197) (#200)

Previously header matching did not match on all headers for
non-inline headers. This patch changes the default behavior to
always logically match on all headers. Multiple individual
headers will be logically concatenated with ',' similar to what
is done with inline headers. This makes the behavior effectively
consistent. This behavior can be temporary reverted by setting
the runtime value "envoy.reloadable_features.header_match_on_all_headers"
to "false".

Targeted fixes have been additionally performed on the following
extensions which make them consider all duplicate headers by default as
a comma concatenated list:
1) Any extension using CEL matching on headers.
2) The header to metadata filter.
3) The JWT filter.
4) The Lua filter.
Like primary header matching used in routing, RBAC, etc. this behavior
can be disabled by setting the runtime value
"envoy.reloadable_features.header_match_on_all_headers" to false.

Finally, the setCopy() header map API previously only set the first
header in the case of duplicate non-inline headers. setCopy() now
behaves similiarly to the other set*() APIs and replaces all found
headers with a single value. This may have had security implications
in the extauth filter which uses this API. This behavior can be disabled
by setting the runtime value
"envoy.reloadable_features.http_set_copy_replace_all_headers" to false.

Fixes https://github.com/envoyproxy/envoy-setec/issues/188

Signed-off-by: Matt Klein <[email protected]>

* backport to v1.15: Fix Kafka Repository Location (#223)

Update mirror used to fetch kafka dependency to a valid, working mirror.

Based on envoyproxy#13025
Resolves envoyproxy#13011

Signed-off-by: Antonio Vicente <[email protected]>

* release: cutting 1.15.1 (#217)

Signed-off-by: Antonio Vicente <[email protected]>

* docs: Fix release notes for v1.15.1 release. (envoyproxy#13318)

Signed-off-by: Antonio Vicente <[email protected]>

* Backport flaky test and tsan fixes to releases/v1.15 branch (envoyproxy#13337)

* hds: fix integration test flakes (envoyproxy#12214)

Part of envoyproxy#12184

Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Antonio Vicente <[email protected]>

* Switch to a tsan-instrumented libc++ for tsan tests (envoyproxy#12134)

This fixes envoyproxy#9784 and re-enables vhds_integration_test

Risk Level: Low, but will most likely increase memory usage

Signed-off-by: Dmitri Dolguikh <[email protected]>

Signed-off-by: Antonio Vicente <[email protected]>

* test: shard hds_integration_test (envoyproxy#12482)

This should avoid TSAN timeout flakes.

Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Antonio Vicente <[email protected]>

* test: shard http2_integration_test (envoyproxy#11939)

This should mitigate TSAN timeout.

Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Antonio Vicente <[email protected]>

* test: fix http2_integration_test flake (envoyproxy#12450)

Fixes envoyproxy#12442

Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Antonio Vicente <[email protected]>

* Kick CI

Signed-off-by: Antonio Vicente <[email protected]>

Co-authored-by: Matt Klein <[email protected]>
Co-authored-by: Dmitri Dolguikh <[email protected]>
Co-authored-by: Lizan Zhou <[email protected]>

* docs: kick off v1.15.3-dev (envoyproxy#13695)

Signed-off-by: Christoph Pakulski <[email protected]>

* 1.15: CI fixes backport (envoyproxy#13697)

Backport following commits to 1.15:
748b2ab (mac ci: try ignoring update failure (envoyproxy#13658), 2020-10-20)
f95f539 (ci: various improvements (envoyproxy#13660), 2020-10-20)
73d78f8 (ci: use multiple stage (envoyproxy#13557), 2020-10-15)
b7a4756 (ci: use azp for api and go-control-plane sync (envoyproxy#13550), 2020-10-14)
876a6bb (ci use azp to sync filter example (envoyproxy#13501), 2020-10-12)
a0f31ee (ci: use azp to generate docs (envoyproxy#13481), 2020-10-12)

Signed-off-by: Lizan Zhou <[email protected]>
Co-authored-by: asraa <[email protected]>

* 1.15: fix CI script (envoyproxy#13724)

Signed-off-by: Lizan Zhou <[email protected]>

* Prevent SEGFAULT when disabling listener (envoyproxy#13515) (envoyproxy#13903)

This prevents the stop_listening overload action from causing
segmentation faults that can occur if the action is enabled after the
listener has already shut down.

Signed-off-by: Alex Konradi <[email protected]>
Signed-off-by: Christoph Pakulski <[email protected]>

* proxy protocol: set downstreamRemoteAddress on StreamInfo (envoyproxy#14131) (envoyproxy#14169)

This fixes a regression which resulted in the downstreamRemoteAddress
on the StreamInfo for a connection not having the address supplied by
the proxy protocol filter, but instead having the address of the
directly connected peer.

This issue does not affect HTTP filters.

Fixes envoyproxy#14087

Signed-off-by: Greg Greenway <[email protected]>
Signed-off-by: Christoph Pakulski <[email protected]>

* ci: temproray disable vhds_integration_test in TSAN (envoyproxy#12067) (envoyproxy#14217)

Signed-off-by: Lizan Zhou <[email protected]>

* tcmalloc changed and the data coming out of tcmalloc::MallocExtension::GetNumericProperty("generic.current_allocated_bytes") (envoyproxy#14165)

Commit Message: tcmalloc changed and the data coming out of tcmalloc::MallocExtension::GetNumericProperty("generic.current_allocated_bytes") no longer appears to be deterministic, even in unthreaded tests. So disable exact mem checks till we sort that out
Additional Description:
Risk Level: low
Testing: just thread_local_store_test
Docs Changes: n/a
Release Notes: n/a

no longer appears to be deterministic, even in unthreaded tests. So disable exact mem checks till we sort that out

Signed-off-by: Joshua Marantz <[email protected]>
Signed-off-by: Christoph Pakulski <[email protected]>

Co-authored-by: Joshua Marantz <[email protected]>

* backport to v1.15: connection: Remember transport socket read resumption requests and replay them when re-enabling read. (envoyproxy#13772) (envoyproxy#14173)

* connection: Remember transport socket read resumption requests and replay them when re-enabling read. (envoyproxy#13772)

Fixes SslSocket read resumption after readDisable when processing the SSL record that contains the last bytes of the HTTP message

Signed-off-by: Antonio Vicente <[email protected]>

* backport to 1.15: udp: properly handle truncated/dropped datagrams (envoyproxy#14122) (envoyproxy#14166)

Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Christoph Pakulski <[email protected]>
Co-authored-by: Matt Klein <[email protected]>
Co-authored-by: Christoph Pakulski <[email protected]>

* backport to 1.15: vrp: allow supervisord to open its log file (envoyproxy#14066) (envoyproxy#14280)

Commit Message: Allow supervisord to open its log file
Additional Description:
Change the default location of the log file and give supervisord
permissions to write to it.

Risk Level: low
Testing: built image locally
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Alex Konradi <[email protected]>
Signed-off-by: Christoph Pakulski <[email protected]>

* rel 1.15: close release 1.15.3 (envoyproxy#14303)

Signed-off-by: Christoph Pakulski <[email protected]>

* Kick off rel 1.15.4. (envoyproxy#14323)

Signed-off-by: Christoph Pakulski <[email protected]>

* backport to 1.15: http: fix datadog and squash handling of responses without body (envoyproxy#13328) (envoyproxy#14458)

Commit Message: Fixing bugs in datadog and sqaush where unexpected bodyless responses would crash Envoy
Risk Level: low
Testing: new unit tests, updated certs
Docs Changes: n/a
Release Notes: inline
Signed-off-by: Christoph Pakulski <[email protected]>
Co-authored-by: alyssawilk <[email protected]>

* backport 1.15: http: fixing a bug with IPv6 hosts (envoyproxy#14273)

Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did.
This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1

Risk Level: low
Testing: new unit, integration tests
Docs Changes: n/a
Release Notes: inline

Signed-off-by: Shikugawa <[email protected]>
Co-authored-by: alyssawilk <[email protected]>

* backport to 1.15: tls: fix detection of the upstream connection close event. (envoyproxy#13858) (envoyproxy#14568)

Fixes envoyproxy#13856.

Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Christoph Pakulski <[email protected]>

Co-authored-by: Piotr Sikora <[email protected]>
Co-authored-by: antonio <[email protected]>
Co-authored-by: Matt Klein <[email protected]>
Co-authored-by: Dmitri Dolguikh <[email protected]>
Co-authored-by: Lizan Zhou <[email protected]>
Co-authored-by: Christoph Pakulski <[email protected]>
Co-authored-by: asraa <[email protected]>
Co-authored-by: Joshua Marantz <[email protected]>
Co-authored-by: Rei Shimizu <[email protected]>
Co-authored-by: alyssawilk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants