Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ScopeTrackedObject crash logging without Envoy signal handler #11984

Closed
mkbehr opened this issue Jul 9, 2020 · 0 comments · Fixed by #12062
Closed

Allow ScopeTrackedObject crash logging without Envoy signal handler #11984

mkbehr opened this issue Jul 9, 2020 · 0 comments · Fixed by #12062
Labels
area/envoy_log

Comments

@mkbehr
Copy link
Contributor

mkbehr commented Jul 9, 2020

We have funcionality for dumping active sessions on crash, as part of issue #7300, but it isn't usable except through Envoy's signal handler: the session dump is only accessible via FatalErrorHandlerInterface, and Envoy::Event::DispatcherImpl won't register its fatal error handler unless Envoy is compiled with ENVOY_HANDLE_SIGNALS. I'd like to add an interface to call into the fatal error handlers from signal handlers other than Envoy's.
@mkbehr mkbehr mentioned this issue Jul 13, 2020
Merged
@dio dio closed this as completed in #12062 Aug 7, 2020
dio pushed a commit that referenced this issue Aug 7, 2020
@mkbehr
signal: Add hooks for calling fatal error handlers from non-envoy sig…
7c92028 
…nal handlers (#12062)

Add hooks for calling fatal error handlers from non-Envoy signal handlers. Move register/removeFatalErrorHandler from SignalAction into a new FatalErrorHandler namespace, and add a new function, callFatalErrorHandlers, which runs the registered error handlers. This makes the crash logging from issue #7300 available for builds that don't use ENVOY_HANDLE_SIGNALS, as long as they do use ENVOY_OBJECT_TRACE_ON_DUMP.

Risk Level: Low
Testing: bazel test //test/...
Docs Changes: N/A
Release Notes: Added
Fixes #11984 

Signed-off-by: Michael Behr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/envoy_log
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

signal: add hooks for calling fatal error handlers from non-envoy signal handlers. mkbehr/envoy
2 participants
@mkbehr @mattklein123