Skip to content

Commit

Permalink
fix comments
Browse files Browse the repository at this point in the history
Signed-off-by: Xuyang Tao <[email protected]>
  • Loading branch information
TAOXUY committed Jan 18, 2021
1 parent ff21619 commit d50f567
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions docs/root/configuration/observability/access_log/usage.rst
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ The following command operators are supported:

%REQUEST_HEADERS_BYTES%
HTTP
Request headers bytes.
Uncompressed bytes of request headers.

TCP
Not implemented (0).
Expand Down Expand Up @@ -222,14 +222,14 @@ The following command operators are supported:

%RESPONSE_HEADERS_BYTES%
HTTP
Response headers bytes.
Uncompressed bytes of response headers.

TCP
Not implemented (0).

%RESPONSE_TRAILERS_BYTES%
HTTP
Response trailers bytes.
Uncompressed bytes of response trailers.

TCP
Not implemented (0).
Expand Down
2 changes: 1 addition & 1 deletion source/common/formatter/substitution_formatter.h
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ class HeaderFormatter {
*/
class HeadersByteSizeFormatter : public FormatterProvider {
public:
// TODO(htuch): Add RequestTrailers here.
// TODO(taoxuy): Add RequestTrailers here.
enum class HeaderType { RequestHeaders, ResponseHeaders, ResponseTrailers };

HeadersByteSizeFormatter(const HeaderType header_type);
Expand Down
12 changes: 6 additions & 6 deletions test/common/access_log/access_log_impl_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,12 @@ name: accesslog
response_headers_.addCopy("response_header_key", "response_header_val");
response_trailers_.addCopy("response_trailer_key", "response_trailer_val");

// request headers:
// :method: GET
// :path: /
// request_header_key: request_header_val

// response headers:
// request headers:
// :method: GET
// :path: /
// request_header_key: request_header_val
//
// response headers:
// response_header_key: response_header_val
//
// response trailers:
Expand Down

0 comments on commit d50f567

Please sign in to comment.