Skip to content

Commit

Permalink
why is this test hanging in CI but not locally?
Browse files Browse the repository at this point in the history
Signed-off-by: Jose Nino <[email protected]>
  • Loading branch information
Jose Nino committed Jun 30, 2020
1 parent 02c34fd commit bc382b0
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions test/integration/server.h
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,13 @@ class NotifyingAllocatorImpl : public Stats::AllocatorImpl {

virtual void waitForCounterFromStringEq(const std::string& name, uint64_t value) {
absl::MutexLock l(&mutex_);
ENVOY_LOG_MISC(trace, "waiting for {} to be {}", name, value);
ENVOY_LOG_MISC(error, "waiting for {} to be {}", name, value);
while (getCounterLockHeld(name) == nullptr || getCounterLockHeld(name)->value() != value) {
ENVOY_LOG_MISC(error, "but {} is currently {}", name,
getCounterLockHeld(name) == nullptr ? -1 : getCounterLockHeld(name)->value());
condvar_.Wait(&mutex_);
}
ENVOY_LOG_MISC(trace, "done waiting for {} to be {}", name, value);
ENVOY_LOG_MISC(error, "done waiting for {} to be {}", name, value);
}

virtual void waitForCounterFromStringGe(const std::string& name, uint64_t value) {
Expand Down

0 comments on commit bc382b0

Please sign in to comment.