Skip to content

Commit

Permalink
android: update version to 29 (#843)
Browse files Browse the repository at this point in the history
Description: actions infra is failing to start android 28. However, android 29 works fine. This PR updates CI to start the android emulator with android 29.
Risk Level: low
Testing: local and CI
Docs Changes: updated the docs to SDK version 29 for requirements

Fixes #841

Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: JP Simard <[email protected]>
  • Loading branch information
junr03 authored and jpsim committed Nov 28, 2022
1 parent 824fe35 commit 65a08b5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions mobile/ci/mac_start_emulator.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

set -e

echo "y" | $ANDROID_HOME/tools/bin/sdkmanager --install 'system-images;android-28;google_apis;x86'
echo "no" | $ANDROID_HOME/tools/bin/avdmanager create avd -n test_android_emulator -k 'system-images;android-28;google_apis;x86' --force
echo "y" | $ANDROID_HOME/tools/bin/sdkmanager --install 'system-images;android-29;google_apis;x86'
echo "no" | $ANDROID_HOME/tools/bin/avdmanager create avd -n test_android_emulator -k 'system-images;android-29;google_apis;x86' --force
nohup $ANDROID_HOME/emulator/emulator -partition-size 1024 -avd test_android_emulator -no-snapshot > /dev/null 2>&1 & $ANDROID_HOME/platform-tools/adb wait-for-device shell 'while [[ -z $(getprop sys.boot_completed | tr -d '\r') ]]; do sleep 1; done; input keyevent 82'
2 changes: 1 addition & 1 deletion mobile/docs/root/start/building/building.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Follow the Envoy instructions `here <https://github.com/envoyproxy/envoy/blob/ma
Android requirements
--------------------

- Android SDK Platform 28
- Android SDK Platform 29
- Android NDK 19.2.5345600

----------------
Expand Down

0 comments on commit 65a08b5

Please sign in to comment.