ci: fix clang-tidy (#10496)

Fixes #9512

Signed-off-by: Lizan Zhou <[email protected]>

.clang-tidy

@@ -1,19 +1,4 @@
-Checks:          'abseil-*,
-                  bugprone-*,
-                  clang-analyzer-*,
-                  clang-diagnostic-*,
-                  misc-unused-using-decls,
-                  modernize-*,
-                  -modernize-pass-by-value,
-                  -modernize-use-trailing-return-type,
-                  performance-*,
-                  readability-braces-around-statements,
-                  readability-container-size-empty,
-                  readability-identifier-naming,
-                  readability-redundant-*'
-
-#TODO(lizan): grow this list, fix possible warnings and make more checks as error
-WarningsAsErrors: 'abseil-duration-*,
+Checks:           'abseil-duration-*,
                    abseil-faster-strsplit-delimiter,
                    abseil-no-namespace,
                    abseil-redundant-strcat-calls,
@@ -51,6 +36,8 @@ WarningsAsErrors: 'abseil-duration-*,
                    readability-redundant-smartptr-get,
                    readability-redundant-string-cstr'
 
+WarningsAsErrors:  '*'
+
 CheckOptions:
   - key:             bugprone-assert-side-effect.AssertMacros
     value:           'ASSERT'

.gitignore

@@ -28,6 +28,7 @@ TAGS
 .vimrc
 .vs
 .vscode
+clang-tidy-fixes.yaml
 clang.bazelrc
 user.bazelrc
 CMakeLists.txt

ci/run_clang_tidy.sh

@@ -8,6 +8,7 @@ export LLVM_CONFIG=${LLVM_CONFIG:-llvm-config}
 LLVM_PREFIX=${LLVM_PREFIX:-$(${LLVM_CONFIG} --prefix)}
 CLANG_TIDY=${CLANG_TIDY:-$(${LLVM_CONFIG} --bindir)/clang-tidy}
 CLANG_APPLY_REPLACEMENTS=${CLANG_APPLY_REPLACEMENTS:-$(${LLVM_CONFIG} --bindir)/clang-apply-replacements}
+FIX_YAML=clang-tidy-fixes.yaml
 
 # Quick syntax check of .clang-tidy.
 ${CLANG_TIDY} -dump-config > /dev/null 2> clang-tidy-config-errors.txt
@@ -57,20 +58,30 @@ function filter_excludes() {
 
 if [[ "${RUN_FULL_CLANG_TIDY}" == 1 ]]; then
   echo "Running full clang-tidy..."
-  "${LLVM_PREFIX}/share/clang/run-clang-tidy.py" \
+  python3 "${LLVM_PREFIX}/share/clang/run-clang-tidy.py" \
     -clang-tidy-binary=${CLANG_TIDY} \
     -clang-apply-replacements-binary=${CLANG_APPLY_REPLACEMENTS} \
+    -export-fixes=${FIX_YAML} \
+    -j ${NUM_CPUS:-0} -p 1 -quiet \
     ${APPLY_CLANG_TIDY_FIXES:+-fix}
 elif [[ "${BUILD_REASON}" != "PullRequest" ]]; then
   echo "Running clang-tidy-diff against previous commit..."
   git diff HEAD^ | filter_excludes | \
-    "${LLVM_PREFIX}/share/clang/clang-tidy-diff.py" \
+    python3 "${LLVM_PREFIX}/share/clang/clang-tidy-diff.py" \
       -clang-tidy-binary=${CLANG_TIDY} \
-      -p 1
+      -export-fixes=${FIX_YAML} \
+      -j ${NUM_CPUS:-0} -p 1 -quiet
 else
   echo "Running clang-tidy-diff against master branch..."
   git diff "remotes/origin/${SYSTEM_PULLREQUEST_TARGETBRANCH}" | filter_excludes | \
-    "${LLVM_PREFIX}/share/clang/clang-tidy-diff.py" \
+    python3 "${LLVM_PREFIX}/share/clang/clang-tidy-diff.py" \
       -clang-tidy-binary=${CLANG_TIDY} \
-      -p 1
+      -export-fixes=${FIX_YAML} \
+      -j ${NUM_CPUS:-0} -p 1 -quiet
+fi
+
+if [[ -s "${FIX_YAML}" ]]; then
+  echo "clang-tidy check failed, potentially fixed by clang-apply-replacements:"
+  cat ${FIX_YAML}
+  exit 1
 fi

test/integration/fake_upstream.cc

@@ -87,6 +87,7 @@ void FakeStream::encodeHeaders(const Http::HeaderMap& headers, bool end_stream)
     headers_copy->addCopy(Http::LowerCaseString("x-served-by"),
                           parent_.connection().localAddress()->asString());
   }
+
   parent_.connection().dispatcher().post([this, headers_copy, end_stream]() -> void {
     encoder_.encodeHeaders(*headers_copy, end_stream);
   });
@@ -107,7 +108,7 @@ void FakeStream::encodeData(uint64_t size, bool end_stream) {
 }
 
 void FakeStream::encodeData(Buffer::Instance& data, bool end_stream) {
-  std::shared_ptr<Buffer::Instance> data_copy(new Buffer::OwnedImpl(data));
+  std::shared_ptr<Buffer::Instance> data_copy = std::make_shared<Buffer::OwnedImpl>(data);
   parent_.connection().dispatcher().post(
       [this, data_copy, end_stream]() -> void { encoder_.encodeData(*data_copy, end_stream); });
 }