comments

Signed-off-by: Dan Zhang <[email protected]>
envoyproxy · Sep 6, 2019 · 548f8f5 · 548f8f5
1 parent 3405bfc
commit 548f8f5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/source/extensions/quic_listeners/quiche/envoy_quic_server_session.cc b/source/extensions/quic_listeners/quiche/envoy_quic_server_session.cc
@@ -110,7 +110,8 @@ void EnvoyQuicServerSession::addConnectionCallbacks(Network::ConnectionCallbacks
 }
 
 void EnvoyQuicServerSession::addBytesSentCallback(Network::Connection::BytesSentCb /*cb*/) {
-  // TODO(danzh): implement to support proxy.
+  // TODO(danzh): implement to support proxy. This interface is only called from
+  // TCP proxy code.
   ASSERT(false, "addBytesSentCallback is not implemented for QUIC");
 }
 

diff --git a/source/extensions/quic_listeners/quiche/envoy_quic_utils.h b/source/extensions/quic_listeners/quiche/envoy_quic_utils.h
@@ -20,6 +20,7 @@ quicAddressToEnvoyAddressInstance(const quic::QuicSocketAddress& quic_address);
 quic::QuicSocketAddress envoyAddressInstanceToQuicSocketAddress(
     const Network::Address::InstanceConstSharedPtr& envoy_address);
 
+// The returned header map has all keys in lower case.
 Http::HeaderMapImplPtr quicHeadersToEnvoyHeaders(const quic::QuicHeaderList& header_list);
 
 Http::HeaderMapImplPtr spdyHeaderBlockToEnvoyHeaders(const spdy::SpdyHeaderBlock& header_block);