comments

Signed-off-by: Alyssa Wilk <[email protected]>
envoyproxy · Nov 15, 2023 · 20beffb · 20beffb
1 parent 910385a
commit 20beffb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/test/extensions/filters/http/admission_control/config_test.cc b/test/extensions/filters/http/admission_control/config_test.cc
@@ -109,6 +109,7 @@ sampling_window: 1337s
       admission_control_filter_factory
           .createFilterFactoryFromProtoTyped(proto, "whatever", dual_info_,
                                              factory_context.getServerFactoryContext())
+          .status()
           .IgnoreError(),
       EnvoyException, "Success rate threshold cannot be less than 1.0%.");
 }

diff --git a/test/extensions/filters/http/aws_lambda/config_test.cc b/test/extensions/filters/http/aws_lambda/config_test.cc
@@ -112,8 +112,9 @@ arn: "arn:aws:lambda:region:424242:fun"
   testing::NiceMock<Server::Configuration::MockFactoryContext> context;
   AwsLambdaFilterFactory factory;
 
-  EXPECT_THROW(factory.createFilterFactoryFromProto(proto_config, "stats", context).value(),
-               EnvoyException);
+  EXPECT_THROW(
+      factory.createFilterFactoryFromProto(proto_config, "stats", context).status().IgnoreError(),
+      EnvoyException);
 }
 
 TEST(AwsLambdaFilterConfigTest, PerRouteConfigWithInvalidARNThrows) {

diff --git a/test/extensions/filters/http/cache/config_test.cc b/test/extensions/filters/http/cache/config_test.cc
@@ -54,8 +54,9 @@ TEST_F(CacheFilterFactoryTest, NoTypedConfig) {
 TEST_F(CacheFilterFactoryTest, UnregisteredTypedConfig) {
   config_.mutable_typed_config()->PackFrom(
       envoy::extensions::filters::http::cache::v3::CacheConfig());
-  EXPECT_THROW(factory_.createFilterFactoryFromProto(config_, "stats", context_).IgnoreError(),
-               EnvoyException);
+  EXPECT_THROW(
+      factory_.createFilterFactoryFromProto(config_, "stats", context_).status().IgnoreError(),
+      EnvoyException);
 }
 
 } // namespace