Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner links dont work in local build #496

Open
phlax opened this issue Dec 11, 2024 · 4 comments
Open

Banner links dont work in local build #496

phlax opened this issue Dec 11, 2024 · 4 comments

Comments

@phlax
Copy link
Member

phlax commented Dec 11, 2024

Currently if you build locally the banner links - ie:

image

they 404

the reason for this is that the links are to eg training rather than training.html - on the real website netlify mangles/redirects these

fixing this is not trivial - we would need to add some nginx config (or similar) to do it.

relatedly the main link goes to the envoy website not to the local site root. This should be an easier fix

@phlax
Copy link
Member Author

phlax commented Dec 11, 2024

cc @missBerg - i think you mentioned this

@MAVRICK-1
Copy link

@phlax can i work on this ?

@phlax
Copy link
Member Author

phlax commented Dec 12, 2024

@MAVRICK-1 for sure - that would be appreciated

this is for the static target in docker-compose

probably the easiest way to resolve is adding a custom nginx config with something like:

server {
    listen 80;
    server_name yourdomain.com;

    location / {
        try_files $uri $uri.html $uri/ =404;
    }
}

@MAVRICK-1
Copy link

MAVRICK-1 commented Dec 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants