swift: handle gRPC compression errors #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Swift gRPC response compression error handling logic to match Android's: - Instead of silently failing, call `onError` in a terminal state and clear out other callbacks - Retain the `GRPCResponseHandler` while the core Envoy engine retains the underlying `onData` callback to ensure that error and message propogation can be called by the handler Context: #472 (comment) Signed-off-by: Michael Rebello <[email protected]>
Merged
buildbreaker
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Swift gRPC response compression error handling logic to match Android's:
onErrorin a terminal state and clear out other callbacksGRPCResponseHandlerwhile the core Envoy engine retains the underlyingonDatacallback to ensure that error and message propogation can be called by the handlerContext: #472 (comment)
Signed-off-by: Michael Rebello [email protected]