-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: more intro and docs outline #22
Conversation
Signed-off-by: Matt Klein <[email protected]>
@junr03 @goaway @buildbreaker these are some getting started docs that should get us in a place where folks can start filling in specific pieces. The "what is Envoy Mobile" page is a lightly edited version of the blog post. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small comments. Otherwise this scaffolding -- and initial content -- lgtm.
new features are added, and eventually split out into proper documentation. Our initial milestones | ||
can be `viewed in GitHub <https://github.com/lyft/envoy-mobile/milestones>`_. | ||
|
||
* Ability to compile Envoy on both Android and iOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be more specific about what we can compile? Maybe not in this PR, but a todo for specifics from @goaway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we should be more specific throughout these docs, but will leave it to others to update when the code and demos are finalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 we have https://github.com/lyft/envoy-edge-dev/issues/65 for demos, and I just created #23 for documenting components.
Signed-off-by: Matt Klein <[email protected]>
@junr03 @buildbreaker updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
new features are added, and eventually split out into proper documentation. Our initial milestones | ||
can be `viewed in GitHub <https://github.com/lyft/envoy-mobile/milestones>`_. | ||
|
||
* Ability to compile Envoy on both Android and iOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 we have https://github.com/lyft/envoy-edge-dev/issues/65 for demos, and I just created #23 for documenting components.
Let's just ship this and we can iterate in parallel. |
Signed-off-by: Matt Klein [email protected]