Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add section for envoy client builder options #715

Closed
junr03 opened this issue Feb 29, 2020 · 2 comments · Fixed by #745
Closed

docs: add section for envoy client builder options #715

junr03 opened this issue Feb 29, 2020 · 2 comments · Fixed by #745
Assignees
@rebello95
Labels
docs

Comments

@junr03
Copy link
Member

junr03 commented Feb 29, 2020

With #714 we now have a handful of builder options. Create a section in starting_envoy.rst that documents them.
@junr03 junr03 added the docs label Feb 29, 2020
@junr03 junr03 self-assigned this Feb 29, 2020
@junr03 junr03 mentioned this issue Feb 29, 2020
Merged
@rebello95
Copy link
Contributor

Thanks for filing this. Happy to take it on as well if you don't get around to it

rebello95 pushed a commit that referenced this issue Mar 2, 2020
@junr03
dns: add ability to set dns failure refresh rate (#714)
824ba9d 
Description: updates envoy ref to include envoyproxy/envoy#10137. Exposes client builder function to add dns failure refresh rate.
Risk Level: low, new configuration option
Testing: local apps, CI
Docs Changes: created #715 to create a section in the docs for all the builder options.

Fixes #673
rebello95 pushed a commit that referenced this issue Mar 3, 2020
@junr03 @rebello95
dns: add ability to set dns failure refresh rate (#714)
e22bb3e 
Description: updates envoy ref to include envoyproxy/envoy#10137. Exposes client builder function to add dns failure refresh rate.
Risk Level: low, new configuration option
Testing: local apps, CI
Docs Changes: created #715 to create a section in the docs for all the builder options.

Fixes #673 
Signed-off-by: Michael Rebello <[email protected]>
@rebello95 rebello95 assigned rebello95 and unassigned junr03 Mar 10, 2020
rebello95 added a commit that referenced this issue Mar 10, 2020
@rebello95
docs: add docs on EnvoyClientBuilder
e21bb28 
Resolves #715.

Signed-off-by: Michael Rebello <[email protected]>
@rebello95 rebello95 mentioned this issue Mar 10, 2020
Merged
@rebello95
Copy link
Contributor

#745

rebello95 added a commit that referenced this issue Mar 10, 2020
@rebello95
docs: add docs on EnvoyClientBuilder (#745)
917186e 
Resolves #715.

Signed-off-by: Michael Rebello <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 28, 2022
@rebello95 @jpsim
docs: add docs on EnvoyClientBuilder (#745)
289b12c 
Resolves envoyproxy/envoy-mobile#715.

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@rebello95 @jpsim
docs: add docs on EnvoyClientBuilder (#745)
4c8b3b0 
Resolves envoyproxy/envoy-mobile#715.

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebello95 rebello95

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add docs on EnvoyClientBuilder envoyproxy/envoy-mobile
2 participants
@rebello95 @junr03