Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: actually turn on liveliness test for iOS #646

Closed
junr03 opened this issue Jan 29, 2020 · 0 comments · Fixed by #648
Closed

ci: actually turn on liveliness test for iOS #646

junr03 opened this issue Jan 29, 2020 · 0 comments · Fixed by #648
Assignees
@junr03
Labels
ci
Milestone
v0.3 "Secondi"

Comments

@junr03
Copy link
Member

junr03 commented Jan 29, 2020

I noticed that the liveliness test for ios in https://github.com/lyft/envoy-mobile/blob/69ef3951c7a2ee82b0155ade8fbd25dce6f4f662/.github/workflows/ios.yml#L56 does not actually grep for liveliness so it is letting broken commits through. For example, #631 broke the iOS build due to a runtime issue with dropped symbols.

Once envoyproxy/envoy#9875 merges, we can update the ref and turn on the iOS liveliness test.
@junr03 junr03 added the ci label Jan 29, 2020
@junr03 junr03 self-assigned this Jan 29, 2020
@junr03 junr03 mentioned this issue Jan 30, 2020
Merged
junr03 added a commit that referenced this issue Jan 30, 2020
@junr03
envoy: move ref back to stable (#648)
b810d86 
Signed-off-by: Jose Nino [email protected]
Description: envoyproxy/envoy#9618 broke the iOS build due to missing symbols. envoyproxy/envoy#9875 fixes. However, in order to expedite a clean master branch this PR moves the Envoy ref back to a stable place. Note that Android logging is reverted. Also note that CI for iOS was not testing for liveliness, which is how the breakage went through in the first place. This PR also fixes that.
Risk Level: low
Testing: CI

Fixes #646

Signed-off-by: Jose Nino <[email protected]>
@junr03 junr03 added this to the v0.3 "Secondi" milestone Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junr03 junr03

Labels
ci
Projects
None yet
Milestone
v0.3 "Secondi"
Development

Successfully merging a pull request may close this issue.

envoy: move ref back to stable envoyproxy/envoy-mobile
1 participant
@junr03