example comment

Signed-off-by: Jose Nino <[email protected]>
envoyproxy · Feb 20, 2020 · 1719bfa · 1719bfa
1 parent d4c65c1
commit 1719bfa
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 0 deletions.
diff --git a/examples/java/hello_world/MainActivity.java b/examples/java/hello_world/MainActivity.java
@@ -74,6 +74,9 @@ protected void onDestroy() {
   }
 
   private void makeRequest() {
+    // Note: this request will use an http/1.1 stream for the upstream request.
+    // The Kotlin example uses h2. This is done on purpose to test both paths in end-to-end tests
+    // in CI.
     Request request =
         new RequestBuilder(RequestMethod.GET, REQUEST_SCHEME, REQUEST_AUTHORITY, REQUEST_PATH)
             .build();

diff --git a/examples/kotlin/hello_world/MainActivity.kt b/examples/kotlin/hello_world/MainActivity.kt
@@ -74,6 +74,9 @@ class MainActivity : Activity() {
   }
 
   private fun makeRequest() {
+    // Note: this request will use an h2 stream for the upstream request.
+    // The Java example uses http/1.1. This is done on purpose to test both paths in end-to-end
+    // tests in CI.
     val request = RequestBuilder(RequestMethod.GET, REQUEST_SCHEME, REQUEST_AUTHORITY, REQUEST_PATH)
         .addUpstreamHttpProtocol(UpstreamHttpProtocol.HTTP2)
         .build()

diff --git a/examples/objective-c/hello_world/ViewController.m b/examples/objective-c/hello_world/ViewController.m
@@ -66,6 +66,9 @@ - (void)performRequest {
   NSLog(@"Starting request to '%@'", _REQUEST_PATH);
 
   int requestID = self.requestCount;
+  // Note: this request will use an http/1.1 stream for the upstream request.
+  // The Swift example uses h2. This is done on purpose to test both paths in end-to-end tests
+  // in CI.
   RequestBuilder *builder = [[RequestBuilder alloc] initWithMethod:RequestMethodGet
                                                             scheme:_REQUEST_SCHEME
                                                          authority:_REQUEST_AUTHORITY

diff --git a/examples/swift/hello_world/ViewController.swift b/examples/swift/hello_world/ViewController.swift
@@ -47,6 +47,9 @@ final class ViewController: UITableViewController {
     NSLog("Starting request to '\(kRequestPath)'")
 
     let requestID = self.requestCount
+    // Note: this request will use an h2 stream for the upstream request.
+    // The Objective-C example uses http/1.1. This is done on purpose to test both paths in
+    // end-to-end tests in CI.
     let request = RequestBuilder(method: .get, scheme: kRequestScheme,
                                  authority: kRequestAuthority,
                                  path: kRequestPath, upstreamHttpProtocol: .http2)