-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set USE_CLANG_CL=1 to force substitute llvm tools #88
Merged
Commits on Jul 24, 2020
-
Set USE_CLANG_CL=1 to force substitute llvm tools
It seems bazel-toolchains does not as of yet let us choose the actual compiler we are targeting so the cc-compiler-x64_windows always points to msvc-cl while on Linux, cc-compiler-k8 points to the correct compiler (gcc or clang etc.). With this change, we are in fact still using the compiler named msvc-cl but the toolchain config points to llvm tools rather than MSVC tools. The MSVC cl.exe and link.exe command syntax is what is common. We may be able to undo this if either Bazel itself is able to change its CC toolchain rules for Windows to match the better Linux pattern (and do away with the USE_CLANG_CL logic) or bazel-toolchains has a good way of specifying a target cpu and compiler (so we can for example specify x64_windows and clang-cl or x64_windows and msvc-cl to get the correct toolchain). Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 83f611a - Browse repository at this point
Copy the full SHA 83f611aView commit details
Commits on Aug 5, 2020
-
Merge remote-tracking branch 'origin/master' into clang-cl-add-env-var
Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a90e7d9 - Browse repository at this point
Copy the full SHA a90e7d9View commit details
Commits on Aug 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 540d799 - Browse repository at this point
Copy the full SHA 540d799View commit details
Commits on Aug 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for aff02b9 - Browse repository at this point
Copy the full SHA aff02b9View commit details -
No change, tickle CI to work around unexpected failure
Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b7399d8 - Browse repository at this point
Copy the full SHA b7399d8View commit details
Commits on Aug 14, 2020
-
Bump bazel-toolchains to pick up fix
Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 57d909e - Browse repository at this point
Copy the full SHA 57d909eView commit details
Commits on Aug 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bbfbc8c - Browse repository at this point
Copy the full SHA bbfbc8cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.