-
Notifications
You must be signed in to change notification settings - Fork 66
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Regenerate windows toolchains from 4e06e4d
[skip ci] Set USE_CLANG_CL=1 to force substitute llvm tools (#88) It seems bazel-toolchains does not as of yet let us choose the actual compiler we are targeting so the cc-compiler-x64_windows always points to msvc-cl while on Linux, cc-compiler-k8 points to the correct compiler (gcc or clang etc.). With this change, we are in fact still using the compiler named msvc-cl but the toolchain config points to llvm tools rather than MSVC tools. The MSVC cl.exe and link.exe command syntax is what is common. We may be able to undo this if either Bazel itself is able to change its CC toolchain rules for Windows to match the better Linux pattern (and do away with the USE_CLANG_CL logic) or bazel-toolchains has a good way of specifying a target cpu and compiler (so we can for example specify x64_windows and clang-cl or x64_windows and msvc-cl to get the correct toolchain). Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
- Loading branch information
Showing
7 changed files
with
41 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters