Merge pull request #51 from envoy/fix-plugin-install-config-catch

SQ-4167: fix promise handling on plugin install config call
envoy · Jan 23, 2024 · 24ec41b · 24ec41b
2 parents dea5dd5 + 0aa1d94
commit 24ec41b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/lib/EnvoyAPI.js b/lib/EnvoyAPI.js
@@ -387,15 +387,14 @@ class EnvoyAPI {
    * @returns {Promise<{}>}
    */
   async getPluginInstallConfig(installId) {
-    return new Promise((resolve, reject) => {
-      this.request({
-        method: 'GET',
-        url: `/api/v2/plugin-services/installs/${installId}/config`,
-      }).then(body => resolve(EnvoyAPI.getDataFromBody(body)))
-        .catch((error) => {
-          EnvoyAPI.safeRequestsError(error).catch((err) => reject(err));
-        });
+    const body = await this.request({
+      method: 'GET',
+      url: `/api/v2/plugin-services/installs/${installId}/config`,
+    }).catch((error) => {
+      return EnvoyAPI.safeRequestsError(error);
     });
+
+    return EnvoyAPI.getDataFromBody(body);
   }
 
   /**

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@envoy/envoy-integrations-sdk",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "description": "",
   "main": "index.js",
   "scripts": {