[Bugfix] Fix SIGABRT in KqueueSelector #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, is there any chance this will be merged? |
bozek-lu
approved these changes
Jan 19, 2021
|
Hi! |
|
Hi @danielaRiesgo, thanks for submitting the PR. Sorry for the late response, this project hasn't been actively maintained. This change looks good though and seems in line with the swift pointer API, so I'll go ahead and merge this. |
Goos
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #78 , which persisted even with #83 fix.
Our team tried this fix over the #83 , so you may want to merge both of them.
We had a SIGABRT and an EXC_BAD_ACCESS before we made this fix. And after restarting simulater and this fix, the tests run smoothly (we use Embassy for UI tests).
Explanation
The array count was incorrectly used.
The documentation says:
Meaning we should not used kevents array in the closure. But then it continues:
So we should use the pointer provided to body, not the count calculated before the function is called.