Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat connection resets as connection closed by peer #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iloveitaly
Copy link

This was the original error message I received:

Embassy/Transport.swift:203: Fatal error: Failed to send, errno=54, message=Connection reset by peer

This was the original error message I received:

Embassy/Transport.swift:203: Fatal error: Failed to send, errno=54, message=Connection reset by peer
@iloveitaly
Copy link
Author

@fangpenlin thoughts on this?

mikebuss added a commit to mikebuss/Embassy that referenced this pull request Nov 20, 2024
@mikebuss
Copy link

I've also had this issue, but my fix involved changing handleRead to return if the read failed. For my use case, this solves the "Connection reset by peer" issue above.

private func handleRead() {
        // ensure we are not closed
        guard !closed else {
            return
        }
        guard reading else {
            return
        }
        var data: Data!
        do {
            data = try socket.recv(size: Transport.recvChunkSize)
        } catch {
            return
        }
        guard data.count > 0 else {
            closedByPeer()
            return
        }
        // ensure we are not closing
        guard !closing else {
            return
        }
        if let callback = readDataCallback {
            callback(data)
        }
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants