Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/hooks rewrite #56

Merged
merged 103 commits into from
Apr 25, 2019
Merged

Feature/hooks rewrite #56

merged 103 commits into from
Apr 25, 2019

Conversation

maschino
Copy link
Member

@maschino maschino commented Apr 1, 2019 •
edited
Loading

Summary

This PR tries to embrace the new hook style of developing react components. The goal is to provide a better api and a more robust and performant base implementation.
Work in progress!

This should resolve the issue of #57
Fixes #58

Checklist

Please ensure that you've fulfilled the following tasks:

  • My code follows the style guides of this project and yarn lint does not throw errors
  • My code is well tested and did not decrease the test coverage
  • All new and existing tests have passed
  • My submission passes the build
  • I've added changes to CHANGELOG.MD
  • I've updated the project documentation

maschino added 30 commits April 1, 2019 22:56
@maschino
Added useFullName hook
b4fe2c3
@maschino
Added useTimeout hook
b82bfde
@maschino
Added useIsUnmounted hook
08d1b30
@maschino
Moved useFormContext hook to new hooks folder
b3d9887
@maschino
Refactored ValidationWrapper to use new useValidation hook
2f9773a
@maschino
Fixed useFormContext import path
9443aa2
@maschino
Refactored global export handling
11d82a9
@maschino
Updated changelog
4a230fe
@maschino
Fixed some import paths to the new hooks
a6705a9
@maschino
Refactored IFieldValues to an interface
cdb9b80
@maschino
Exported IBasicValidationState interface
2a99eaa
@maschino
Refactored useFormContext to a function
ba7c966
@maschino
Added useFieldRegistration hook
b65be13
@maschino
Began FieldGroup hooks rewrite
3f88d81
@maschino
Removed old FieldGroup implementations
a93775b
@maschino
Fixed Form typing issues
039d464
@maschino
Fixed import path
bc6958f
@maschino
Fixed some FieldGroup unit test typing issues
e1ca96f
@maschino
Added react-hooks-testing-library for unit testing
a859478
@maschino
Added useFullName unit test
71df333
@maschino
Added unit test for useFieldRegistration
2e77655
@maschino
Moved FormContext test to useFormContext test
d60cab5
@maschino
Added useIsUnmounted unit test
130f319
@maschino
Added missing semicolon
7e33571
@maschino
Added useTimeout unit test
2ca7cb2
@maschino
Removed irrelevant dependency
efd6937
@maschino
Adapted FieldGroup unit test
947f30e
@maschino
Updated snapshot
19cc55f
@maschino
Fixed FormButton unit test
2e48fdf
@maschino
Added useFieldGroup unit test, corrected defaultValues and values beh…
7be63d3 
…aviour
maschino added 27 commits April 14, 2019 22:13
@maschino
Added styleguidist and updated jsdocs to old showcase
3efca4c
@maschino
Added useFormEventListener hook
bb7b6ba
@maschino
Rewritten Input to use new useField hook
5055419
@maschino
Fixed a reset issue in useField
d41e005
@maschino
Temporarely fixed circular dependency due to FormContext import
1d87bd0
@maschino
Removed stringFormatter from FieldError props
8ca3623
@maschino
Rewritten ValidationSummary to use hooks
798ef14
@maschino
Added unit test for useValidationSummary
d6c85fd
@maschino
Added ValidationSummary unit tests
8ff3398
@maschino
Removed toArray util due to low usage
b6fc2d9
@maschino
Removed test-utils from production build
96ff54c
@maschino
Only globally export some utils
310c093
@maschino
Improved typings in FieldGroup, reverted breaking change
6e97385
@maschino
Improved typings in FieldLine
35ca9f3
@maschino
Improved typings in FormButton
626e0e0
@maschino
Improved typings in FormText
20440c2
@maschino
Improved typings in ValidationSummary
70f7f92
@maschino
Improved typings in hocs
4978f93
@maschino
Added type export for non breaking change
99c54d7
@maschino
Updated util removal in changelog
379d172
@maschino
Version bump to 3.0.0-alpha.1
daf360c
@maschino
Added missing exports that introduced breaking changes
0ec6341
@maschino
Improved styleguide documentation
fe4958d
@maschino
Added IValidatedComponentProps type alias for backwards compatiblity
15db0b6
@maschino
Added type parameters to Form
ddd2b8f
@maschino
Updated dependencies
c686a4a
@maschino
Refactored hook unit tests due to changes in react-hooks-testing-library
c0c7d95
@maschino maschino merged commit 744a1c6 into master Apr 25, 2019
@maschino maschino deleted the feature/hooks-rewrite branch April 25, 2019 19:26
maschino added a commit to maschino/react-ocean-forms that referenced this pull request Mar 28, 2020
@maschino
Merge pull request environment-agency-austria#56 from environment-age…
664249d 
…ncy-austria/hotfix/DatePicker-empty-value

Hotfix for DatePicker onChange not triggering with empty string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work in progress
Projects
None yet
Milestone
v3 - Hooks improvements
Development

Successfully merging this pull request may close these issues.

An in-range update of rollup is breaking the build 🚨
2 participants
@maschino @coveralls