refactor: extract month slider into its own component #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekeih
commented
Feb 1, 2024
ekeih
force-pushed
the
extract-month-slider
branch
2 times, most recently
from
0e0a640
to
bf1c5be
Compare
malfynnction
reviewed
Mar 7, 2024
src/components/MonthSlider.tsx
Outdated
Comment on lines
51
to
52
| const activeMonth = | ||
| searchParams.get('month')?.substring(0, 7) || monthYearFromDate(new Date()) |
There was a problem hiding this comment.
I think it makes more sense to pass this in the props. Depending on the usecase, we might not always encode the month in the url, and even if we do it doesn't make sense to parse it both in the Dashboard.tsx and here.
There was a problem hiding this comment.
Thanks for the feedback, I changed it in e7742d9. Is this what you had in mind?
ekeih
force-pushed
the
extract-month-slider
branch
from
bf1c5be
to
e7742d9
Compare
This makes it possible to use the slider on other pages. I am currently working on a statistics page which uses the slider as well. Merging this refactor prevents future merge conflicts.
ekeih
force-pushed
the
extract-month-slider
branch
from
e7742d9
to
ba33b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use the slider on other pages. I am currently working on a statistics page which uses the slider as well. Merging this refactor prevents future merge conflicts.