fix: response for wrong filter directions can now be unmarshaled #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
=======================================
Coverage 80.89% 80.90%
=======================================
Files 53 53
Lines 3921 3922 +1
=======================================
+ Hits 3172 3173 +1
Misses 599 599
Partials 150 150 ☔ View full report in Codecov by Sentry. |
morremeyer
force-pushed
the
fix/filter-direction-errors
branch
from
6818af5
to
3d54722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting a transaction list with an invalid direction led to a response that was not valid JSON.
This was due to the Unmarshaling in tests not being done correctly.
This PR resolves the Unmarshal error and the broken response at the same time.