Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ics security patch #77

Merged
merged 8 commits into from
Oct 17, 2022
Merged

update ics security patch #77

merged 8 commits into from
Oct 17, 2022

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Oct 14, 2022

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@790aece). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage        ?   54.19%           
=======================================
  Files           ?       23           
  Lines           ?     2144           
  Branches        ?        0           
=======================================
  Hits            ?     1162           
  Misses          ?      914           
  Partials        ?       68           

@aleem1314
Copy link
Collaborator

Can you also bump the SDK to latest version?

aleem1314
aleem1314 previously approved these changes Oct 15, 2022
@anilcse
Copy link
Collaborator Author

anilcse commented Oct 17, 2022

Closing in favour of #78

@anilcse anilcse closed this Oct 17, 2022
@anilcse
Copy link
Collaborator Author

anilcse commented Oct 17, 2022

opening this as we need to move fast

@anilcse anilcse reopened this Oct 17, 2022
…nberry-update

# Conflicts:
#	go.mod
#	go.sum
@anilcse anilcse mentioned this pull request Oct 17, 2022
19 tasks
@anilcse anilcse merged commit e00e301 into main Oct 17, 2022
@anilcse anilcse deleted the cosmos/dragonberry-update branch October 17, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants